Pipeline dumps are very useful for debugging. Right now we have one for PlaybackPipeline but none for AppendPipeline.
Created attachment 323164 [details] Patch
Comment on attachment 323164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323164&action=review > Source/WebCore/ChangeLog:3 > + [GTK][MSE] Add dump of append pipeline The whole patch looks very good. I would just rename the bug to "[MSE][GStreamer] ..." because it applies to all GStreamer ports (GTK, WPE or any other in the future).
Comment on attachment 323164 [details] Patch I agree with Enrique. This said, the patch is good enough and we can land it provided that you create a bug (and fix if if you can) to rework the way we subscribe and unsubscribe to signals in this and other pipelines. First. we should subscribe with lambdas. Second, we should unsubscribe with the by_data function instead of the by_func one. That way, as we always pass this as user_data, we'll always unsubscribe from stuff even when we haven't done it explicitly for all functions (and we won't need declared functions, lambdas will suffice).
Created attachment 323165 [details] Patch
Comment on attachment 323165 [details] Patch By request of Alicia, we set cq- because she can't check the landing now.
Comment on attachment 323165 [details] Patch Clearing flags on attachment: 323165 Committed r223172: <http://trac.webkit.org/changeset/223172>
All reviewed patches have been landed. Closing bug.