Bug 178073 – Don't use intrinsic width if our container's width is zero

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Tim Horton]

Steps to Reproduce:

1. Using the attached test case, resize your browser window to the minimum width.

Expected:

The SVG line should not be visible.

Actual:

The SVG line discontinuously jumps to overlap the text in the next grid column when the width reaches 0.

Notes:

Chrome and Firefox both behave more sensibly (though they do not agree about the correct behavior).

[Tim Horton]

Created attachment 323160 [details]
testcase

[Tim Horton]

Created attachment 323161 [details]
screenshot of safari (bad case)

[Manuel Rego Casasnovas]

Created attachment 323172 [details]
Another example to reproduce the issue


The problem is easily reproducible with an image too.
Check the new attached example, the size of the image depends on the "1fr" column. When it's very close to 0, the image is size 100% of the column breadth, but when it goes to 0 then the image uses the intrisic size for width (100px in the example).
In Chromium and Firefox the image just disppears when the column size is 0px.
We need to investigate what's going on with that image, and why it's not using the 0px breadth of the column to resolve its 100% width.

The differences between Firefox and Chromium in the first example might be related to the intrinsic size of the SVG or something like that.

[Manuel Rego Casasnovas]

Created attachment 323173 [details]
Simplified test case

This last example is even more simple, just a grid with a column of 0px.
Then the image has a 100% width and is inside a grid item on the first column.
The width of the image should be 0px but it's 100px.

[Manuel Rego Casasnovas]

Ok so the issue is not related to Grid Layout but is a generic issue for replaced elements.

It has been fixed a while ago in Blink: https://codereview.chromium.org/253743008/
But it seems the patch was never imported into WebKit.

The patch is quite small so I guess we can easily import it.

[Manuel Rego Casasnovas]

Created attachment 323664 [details]
Patch

[Manuel Rego Casasnovas]

The patch is missing the Mac baselines for width100percent-image.html but I'll get them from the EWS.

[Build Bot]

Comment on attachment 323664 [details]
Patch

Attachment 323664 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4844499

New failing tests:
fast/replaced/width100percent-image.html

[Build Bot]

Created attachment 323665 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323664 [details]
Patch

Attachment 323664 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4844481

New failing tests:
fast/replaced/width100percent-image.html

[Build Bot]

Created attachment 323666 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323664 [details]
Patch

Attachment 323664 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4844561

New failing tests:
fast/replaced/width100percent-image.html

[Build Bot]

Created attachment 323669 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Manuel Rego Casasnovas]

Created attachment 323680 [details]
Patch

[Build Bot]

Comment on attachment 323680 [details]
Patch

Attachment 323680 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4846322

New failing tests:
http/tests/loading/basic-credentials-sent-automatically.html

[Build Bot]

Created attachment 323702 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Sergio Villar Senin]

Comment on attachment 323680 [details]
Patch

Makes sense. Bonus points for interoperability

[Manuel Rego Casasnovas]

Created attachment 323889 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 323889 [details]
Patch for landing

Clearing flags on attachment: 323889

Committed r223389: <https://trac.webkit.org/changeset/223389>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35005193>