Bug 178068 - Web Inspector: add autocompletion for min/max within a CSS calc
Summary: Web Inspector: add autocompletion for min/max within a CSS calc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-08 15:04 PDT by Devin Rousso
Modified: 2017-10-08 18:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2017-10-08 15:04 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2017-10-08 16:33 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-10-08 15:04:13 PDT 
When typing the following

    width: calc(m|

we should show autocompletions for "min()" and "max()", as they are now supported for CSS calc.
Comment 1 Devin Rousso 2017-10-08 15:04:58 PDT 
Created attachment 323145 [details]
Patch
Comment 2 Joseph Pecoraro 2017-10-08 15:25:18 PDT 
Comment on attachment 323145 [details]
Patch

Heh, I did this the other day and decided against it. I can't remember my reasons though, so lets do it.

Can calc be recursive? So should calc be in this list?
Comment 3 Devin Rousso 2017-10-08 16:33:04 PDT 
Created attachment 323148 [details]
Patch
Comment 4 WebKit Commit Bot 2017-10-08 18:10:47 PDT 
Comment on attachment 323148 [details]
Patch

Clearing flags on attachment: 323148

Committed r223038: <http://trac.webkit.org/changeset/223038>
Comment 5 WebKit Commit Bot 2017-10-08 18:10:48 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-10-08 18:11:37 PDT 
<rdar://problem/34877729>