WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 178057
Update HTMLOListElement.start to behavior from latest HTML specification
https://bugs.webkit.org/show_bug.cgi?id=178057
Summary
Update HTMLOListElement.start to behavior from latest HTML specification
Darin Adler
Reported
2017-10-07 18:29:30 PDT
Update HTMLOListElement.start to behavior from latest HTML specification
Attachments
Patch
(11.41 KB, patch)
2017-10-07 18:35 PDT
,
Darin Adler
cdumez
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-cq-02 for mac-elcapitan
(989.94 KB, application/zip)
2017-10-08 10:44 PDT
,
WebKit Commit Bot
no flags
Details
Archive of layout-test-results from ews100 for mac-elcapitan
(1010.26 KB, application/zip)
2017-10-08 12:54 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
(1.14 MB, application/zip)
2017-10-08 12:59 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews124 for ios-simulator-wk2
(961.56 KB, application/zip)
2017-10-08 13:08 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews112 for mac-elcapitan
(1.78 MB, application/zip)
2017-10-08 13:48 PDT
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2017-10-07 18:35:59 PDT
Created
attachment 323110
[details]
Patch
Chris Dumez
Comment 2
2017-10-07 19:03:35 PDT
***
Bug 163752
has been marked as a duplicate of this bug. ***
Chris Dumez
Comment 3
2017-10-07 19:06:02 PDT
I was waiting for the Chrome UseCounter data to determine if it was safe. Looks like they have UseCounter data now:
https://www.chromestatus.com/metrics/feature/timeline/popularity/2011
And they decided it was safe enough to make the change via:
https://bugs.chromium.org/p/chromium/issues/detail?id=657972
Darin Adler
Comment 4
2017-10-07 23:35:27 PDT
Thanks for the review and confirmation that it’s OK to make this change. I’d really love to have the EWS confirm the tests pass before I land this.
WebKit Commit Bot
Comment 5
2017-10-08 10:44:54 PDT
Comment on
attachment 323110
[details]
Patch Rejecting
attachment 323110
[details]
from commit-queue. New failing tests: fast/lists/ol-reversed-simple.html fast/lists/ol-reversed-simple.xhtml Full output:
http://webkit-queues.webkit.org/results/4793379
WebKit Commit Bot
Comment 6
2017-10-08 10:44:55 PDT
Created
attachment 323133
[details]
Archive of layout-test-results from webkit-cq-02 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 7
2017-10-08 12:54:24 PDT
Comment on
attachment 323110
[details]
Patch
Attachment 323110
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/4794048
New failing tests: fast/lists/ol-reversed-simple.html fast/lists/ol-reversed-simple.xhtml
Build Bot
Comment 8
2017-10-08 12:54:26 PDT
Created
attachment 323135
[details]
Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 9
2017-10-08 12:59:34 PDT
Comment on
attachment 323110
[details]
Patch
Attachment 323110
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/4794057
New failing tests: fast/lists/ol-reversed-simple.html fast/lists/ol-reversed-simple.xhtml
Build Bot
Comment 10
2017-10-08 12:59:36 PDT
Created
attachment 323136
[details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 11
2017-10-08 13:08:17 PDT
Comment on
attachment 323110
[details]
Patch
Attachment 323110
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/4794015
New failing tests: fast/lists/ol-reversed-simple.html fast/lists/ol-reversed-simple.xhtml
Build Bot
Comment 12
2017-10-08 13:08:18 PDT
Created
attachment 323137
[details]
Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Build Bot
Comment 13
2017-10-08 13:48:02 PDT
Comment on
attachment 323110
[details]
Patch
Attachment 323110
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/4794188
New failing tests: fast/lists/ol-reversed-simple.html fast/lists/ol-reversed-simple.xhtml
Build Bot
Comment 14
2017-10-08 13:48:03 PDT
Created
attachment 323140
[details]
Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Darin Adler
Comment 15
2017-10-08 17:11:53 PDT
Committed
r223036
: <
http://trac.webkit.org/changeset/223036
>
Radar WebKit Bug Importer
Comment 16
2017-10-08 17:13:20 PDT
<
rdar://problem/34877494
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug