Bug 178057 - Update HTMLOListElement.start to behavior from latest HTML specification
Summary: Update HTMLOListElement.start to behavior from latest HTML specification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
: 163752 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-10-07 18:29 PDT by Darin Adler
Modified: 2017-10-08 17:13 PDT (History)
9 users (show)

See Also:


Attachments
Patch (11.41 KB, patch)
2017-10-07 18:35 PDT, Darin Adler
cdumez: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-02 for mac-elcapitan (989.94 KB, application/zip)
2017-10-08 10:44 PDT, WebKit Commit Bot
no flags Details
Archive of layout-test-results from ews100 for mac-elcapitan (1010.26 KB, application/zip)
2017-10-08 12:54 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.14 MB, application/zip)
2017-10-08 12:59 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (961.56 KB, application/zip)
2017-10-08 13:08 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.78 MB, application/zip)
2017-10-08 13:48 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2017-10-07 18:29:30 PDT
Update HTMLOListElement.start to behavior from latest HTML specification
Comment 1 Darin Adler 2017-10-07 18:35:59 PDT
Created attachment 323110 [details]
Patch
Comment 2 Chris Dumez 2017-10-07 19:03:35 PDT
*** Bug 163752 has been marked as a duplicate of this bug. ***
Comment 3 Chris Dumez 2017-10-07 19:06:02 PDT
I was waiting for the Chrome UseCounter data to determine if it was safe. Looks like they have UseCounter data now:
https://www.chromestatus.com/metrics/feature/timeline/popularity/2011

And they decided it was safe enough to make the change via:
https://bugs.chromium.org/p/chromium/issues/detail?id=657972
Comment 4 Darin Adler 2017-10-07 23:35:27 PDT
Thanks for the review and confirmation that it’s OK to make this change. I’d really love to have the EWS confirm the tests pass before I land this.
Comment 5 WebKit Commit Bot 2017-10-08 10:44:54 PDT
Comment on attachment 323110 [details]
Patch

Rejecting attachment 323110 [details] from commit-queue.

New failing tests:
fast/lists/ol-reversed-simple.html
fast/lists/ol-reversed-simple.xhtml
Full output: http://webkit-queues.webkit.org/results/4793379
Comment 6 WebKit Commit Bot 2017-10-08 10:44:55 PDT
Created attachment 323133 [details]
Archive of layout-test-results from webkit-cq-02 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-10-08 12:54:24 PDT
Comment on attachment 323110 [details]
Patch

Attachment 323110 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4794048

New failing tests:
fast/lists/ol-reversed-simple.html
fast/lists/ol-reversed-simple.xhtml
Comment 8 Build Bot 2017-10-08 12:54:26 PDT
Created attachment 323135 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-10-08 12:59:34 PDT
Comment on attachment 323110 [details]
Patch

Attachment 323110 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4794057

New failing tests:
fast/lists/ol-reversed-simple.html
fast/lists/ol-reversed-simple.xhtml
Comment 10 Build Bot 2017-10-08 12:59:36 PDT
Created attachment 323136 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 11 Build Bot 2017-10-08 13:08:17 PDT
Comment on attachment 323110 [details]
Patch

Attachment 323110 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4794015

New failing tests:
fast/lists/ol-reversed-simple.html
fast/lists/ol-reversed-simple.xhtml
Comment 12 Build Bot 2017-10-08 13:08:18 PDT
Created attachment 323137 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 13 Build Bot 2017-10-08 13:48:02 PDT
Comment on attachment 323110 [details]
Patch

Attachment 323110 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4794188

New failing tests:
fast/lists/ol-reversed-simple.html
fast/lists/ol-reversed-simple.xhtml
Comment 14 Build Bot 2017-10-08 13:48:03 PDT
Created attachment 323140 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 15 Darin Adler 2017-10-08 17:11:53 PDT
Committed r223036: <http://trac.webkit.org/changeset/223036>
Comment 16 Radar WebKit Bug Importer 2017-10-08 17:13:20 PDT
<rdar://problem/34877494>