Bug 178054 - Octane/splay can leak memory due to stray pointers on the stack when run from the command line
Summary: Octane/splay can leak memory due to stray pointers on the stack when run from...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-07 16:37 PDT by Filip Pizlo
Modified: 2017-10-07 18:14 PDT (History)
2 users (show)

See Also:

Attachments
the patch (8.67 KB, patch)
2017-10-07 16:38 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (9.65 KB, patch)
2017-10-07 17:51 PDT, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-10-07 16:37:29 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-10-07 16:38:30 PDT 
Created attachment 323106 [details]
the patch
Comment 2 Filip Pizlo 2017-10-07 17:51:12 PDT 
Created attachment 323108 [details]
the patch
Comment 3 Saam Barati 2017-10-07 17:59:15 PDT 
Comment on attachment 323108 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323108&action=review

> Source/JavaScriptCore/runtime/VM.cpp:-454
> -{ 

Please revert
Comment 4 Filip Pizlo 2017-10-07 18:13:23 PDT 
Landed in https://trac.webkit.org/changeset/223024/webkit
Comment 5 Radar WebKit Bug Importer 2017-10-07 18:14:04 PDT 
<rdar://problem/34874053>