Bug 178035 - Reduce includes in Document.h
Summary: Reduce includes in Document.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-06 16:12 PDT by Alex Christensen
Modified: 2017-10-09 10:25 PDT (History)
9 users (show)

See Also:


Attachments
Patch (26.91 KB, patch)
2017-10-06 16:13 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2017-10-07 12:52 PDT, Alex Christensen
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-10-06 16:12:48 PDT
Reduce includes in Document.h
Comment 1 Alex Christensen 2017-10-06 16:13:28 PDT
Created attachment 323060 [details]
Patch
Comment 2 Build Bot 2017-10-06 16:15:28 PDT
Attachment 323060 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/HashCountedSet.h:290:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/HashCountedSet.h:297:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/HashCountedSet.h:304:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/HashCountedSet.h:311:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/HashCountedSet.h:318:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: Source/WTF/wtf/Forward.h:34:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 7 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2017-10-07 12:52:35 PDT
Created attachment 323099 [details]
Patch
Comment 4 Darin Adler 2017-10-07 17:14:20 PDT
Comment on attachment 323099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323099&action=review

> Source/WebCore/dom/Document.h:186
> +template<typename> class ExceptionOr;

Should probably do this in a lot of other files.
Comment 5 Alex Christensen 2017-10-09 10:24:57 PDT
http://trac.webkit.org/r223049
Comment 6 Radar WebKit Bug Importer 2017-10-09 10:25:59 PDT
<rdar://problem/34888220>