RESOLVED FIXED 178035
Reduce includes in Document.h
https://bugs.webkit.org/show_bug.cgi?id=178035
Summary Reduce includes in Document.h
Alex Christensen
Reported 2017-10-06 16:12:48 PDT
Reduce includes in Document.h
Attachments
Patch (26.91 KB, patch)
2017-10-06 16:13 PDT, Alex Christensen
no flags
Patch (1.65 KB, patch)
2017-10-07 12:52 PDT, Alex Christensen
darin: review+
Alex Christensen
Comment 1 2017-10-06 16:13:28 PDT
Build Bot
Comment 2 2017-10-06 16:15:28 PDT
Attachment 323060 [details] did not pass style-queue: ERROR: Source/WTF/wtf/HashCountedSet.h:290: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/HashCountedSet.h:297: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/HashCountedSet.h:304: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/HashCountedSet.h:311: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/HashCountedSet.h:318: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WTF/wtf/Forward.h:34: More than one command on the same line [whitespace/newline] [4] Total errors found: 7 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2017-10-07 12:52:35 PDT
Darin Adler
Comment 4 2017-10-07 17:14:20 PDT
Comment on attachment 323099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323099&action=review > Source/WebCore/dom/Document.h:186 > +template<typename> class ExceptionOr; Should probably do this in a lot of other files.
Alex Christensen
Comment 5 2017-10-09 10:24:57 PDT
Radar WebKit Bug Importer
Comment 6 2017-10-09 10:25:59 PDT
Note You need to log in before you can comment on or make changes to this bug.