Bug 178032 - Teach InlineTextBox::clampOffset() about combined text and hyphenation
Summary: Teach InlineTextBox::clampOffset() about combined text and hyphenation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 138913 178322
  Show dependency tree / graph
 
Reported: 2017-10-06 15:27 PDT by Daniel Bates
Modified: 2017-10-15 15:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.21 KB, patch)
2017-10-06 16:24 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (11.72 KB, patch)
2017-10-09 10:08 PDT, Daniel Bates 		zalan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-10-06 15:27:47 PDT 
As a first steps towards fixing bug #138913, teach InlineTextBox::clampOffset() about combined text and hyphenation.
Comment 1 Daniel Bates 2017-10-06 16:24:05 PDT 
Created attachment 323062 [details]
Patch
Comment 2 Daniel Bates 2017-10-09 10:08:41 PDT 
Created attachment 323183 [details]
Patch
Comment 3 Daniel Bates 2017-10-12 08:41:28 PDT 
Comment on attachment 323183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323183&action=review

> Source/WebCore/rendering/InlineTextBox.cpp:629
> +        // Fix up the offset if we are combined text or have a hyphen. We treat combined text as a

Will update this comment to read:

Fix up the offset if we are combined text or have a hyphen because we manage these embellishments. That is, they are not reflected in renderer().text(). We treat combined text as a single unit. We also treat the last codepoint in this box and the hyphen as a single unit.
Comment 4 Daniel Bates 2017-10-12 14:31:45 PDT 
Committed r223259: <https://trac.webkit.org/changeset/223259>
Comment 5 Radar WebKit Bug Importer 2017-10-12 14:32:41 PDT 
<rdar://problem/34964018>