Bug 17803 – Can't build ThreadingPthreads.cpp in non-pch build; can't build pcre_exec.cpp with -DDEBUG

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Mentovai]

During a non-precompiled header build, wtf/ThreadingPthreads.cpp compilation fails for want of a declaration of gettimeofday.  ThreadingPthreads.cpp includes time.h, but should include sys/time.h.  sys/time.h will bring in time.h under normal circumstances.

During a build with -DDEBUG set (the checked-in project file does not set -DDEBUG, but it's not abnormal for -DDEBUG to be set in debug builds), pcre/pcre_exec.cpp compilation fails because rc is not defined.  rc is used in two DPRINTF statements, which are only used when DEBUG is defined.  rc is a typo, these DPRINTFs should use returnCode.

[Mark Mentovai]

Created attachment 19708 [details]
Fix #include in ThreadingPthreads.cpp, fix variable name in pcre_exec.cpp

[Eric Seidel (no email)]

Comment on attachment 19708 [details]
Fix #include in ThreadingPthreads.cpp, fix variable name in pcre_exec.cpp

oops.  rc vs. returnCode was my fault I bet.  sys/time.h includes time.h, so that should be fine.
r=me.

[Eric Seidel (no email)]

Thank you mark for making such easy-to-land patches.  These took only a few minutes to land on my train ride home. :)

These are revisions r31048 through r31053