Bug 178015 - Web Inspector: Network Tab - Row wrapping (waterfall displaying behind next row's name)
Summary: Web Inspector: Network Tab - Row wrapping (waterfall displaying behind next r...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
Keywords: InRadar
Depends on:
Reported: 2017-10-06 10:21 PDT by BJ Burg
Modified: 2017-10-09 12:33 PDT (History)
5 users (show)

See Also:

[SCREENSHOT] unexpanded table (533.89 KB, image/png)
2017-10-06 10:21 PDT, BJ Burg
no flags Details
[SCREENSHOT] selected a row (306.32 KB, image/png)
2017-10-06 10:22 PDT, BJ Burg
no flags Details
[PATCH] Proposed Fix (1.45 KB, patch)
2017-10-08 14:58 PDT, Joseph Pecoraro
bburg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-10-06 10:21:24 PDT
This goes away when selecting a table row. Probably bad CSS?
Comment 1 BJ Burg 2017-10-06 10:21:45 PDT
Created attachment 323024 [details]
[SCREENSHOT] unexpanded table
Comment 2 BJ Burg 2017-10-06 10:22:44 PDT
Created attachment 323025 [details]
[SCREENSHOT] selected a row
Comment 3 BJ Burg 2017-10-06 10:23:14 PDT
This happens for me on my iMac 5K retina screen.
Comment 4 Joseph Pecoraro 2017-10-06 10:26:26 PDT
On non-retina this only happens at super small widths (where the min-size of a column is not taken into account for columnWidths). Here it appears to happen at a wide width, so I suspect this because Retina has half pixel borders and the total width is calculated incorrectly.

I'll look into this soon.
Comment 5 Radar WebKit Bug Importer 2017-10-06 10:27:24 PDT
Comment 6 Joseph Pecoraro 2017-10-08 14:58:20 PDT
Created attachment 323144 [details]
[PATCH] Proposed Fix

This fixes the issue for me on non-Retina. I'll have to test this on Retina before landing though to make sure I addressed the actual original issue.
Comment 7 Joseph Pecoraro 2017-10-09 11:19:40 PDT
Comment on attachment 323144 [details]
[PATCH] Proposed Fix

Looks good on Retina.
Comment 8 BJ Burg 2017-10-09 11:23:46 PDT
Comment on attachment 323144 [details]
[PATCH] Proposed Fix

r=me, verified on retina machine.
Comment 9 Joseph Pecoraro 2017-10-09 12:33:14 PDT