Bug 178012 – run-webkit-tests: upload test results to multiple servers

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Currently, we only allow results to be uploaded to a single server.  There is no reason to force this limitation, and it makes developing a new database to hold results more difficult.  run-webkit-tests should accept a list of results servers so that we can send results to multiple servers.

[Radar WebKit Bug Importer]

<rdar://problem/34856501>

[Jonathan Bedard]

Created attachment 323034 [details]
Patch

[Lucas Forschler]

Comment on attachment 323034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323034&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:395
>          """Download JSON file that only contains test

Since you are adding server_index here, you should bubble it up to get_json, as an entry point for utilizing the new functionality.

[Jonathan Bedard]

Created attachment 323233 [details]
Patch

[Lucas Forschler]

Comment on attachment 323233 [details]
Patch

This looks good to me. Do you want to try and test it on the UAT server before pushing to production? We likely need to verify functionality for WebKit and Internal, although I expect if it works for one, it will work for the other.
Can we add a unit test which tests 0, 1, >1 results servers?

[Jonathan Bedard]

(In reply to Lucas Forschler from comment #5)
> Comment on attachment 323233 [details]
> Patch
> 
> This looks good to me. Do you want to try and test it on the UAT server
> before pushing to production? We likely need to verify functionality for
> WebKit and Internal, although I expect if it works for one, it will work for
> the other.
> Can we add a unit test which tests 0, 1, >1 results servers?

I have tested this when running a server locally.

As for the unit tests, we should have better testing for uploading, but since we don't have unit tests for uploading at all, I don't think we should add them in this patch.  Essentially, they will need to be integration tests because in order to test uploading, we will need to start a results server.  I'll file a bug for that.

[Jonathan Bedard]

https://bugs.webkit.org/show_bug.cgi?id=178131 tracks adding the tests.

[WebKit Commit Bot]

Comment on attachment 323233 [details]
Patch

Clearing flags on attachment: 323233

Committed r223132: <http://trac.webkit.org/changeset/223132>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jonathan Bedard]

Everything seems to be happily uploading to results servers.