RESOLVED FIXED 178007
Always invoke RenderObject::insertedIntoTree/willBeRemovedFromTree 
https://bugs.webkit.org/show_bug.cgi?id=178007
Summary Always invoke RenderObject::insertedIntoTree/willBeRemovedFromTree
Antti Koivisto
Reported 2017-10-06 05:27:45 PDT
These call are currently skipped in some cases making them bug prone and difficult to reason about. This is done as an optimization that doesn't appear valuable anymore.
Attachments
patch (26.97 KB, patch)
2017-10-06 05:30 PDT, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews115 for mac-elcapitan (1.61 MB, application/zip)
2017-10-06 22:13 PDT, Build Bot 		no flags
Details
Patch (33.83 KB, patch)
2017-11-15 21:48 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (34.21 KB, patch)
2017-11-16 10:28 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (34.34 KB, patch)
2017-11-16 11:42 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-10-06 05:30:56 PDT
Created attachment 323010 [details] patch
Build Bot
Comment 2 2017-10-06 22:13:29 PDT
Comment on attachment 323010 [details] patch Attachment 323010 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4787643 Number of test failures exceeded the failure limit.
Build Bot
Comment 3 2017-10-06 22:13:31 PDT
Created attachment 323084 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Aakash Jain
Comment 4 2017-10-08 11:33:26 PDT
Surprisingly, a lot of EWS bots (e.g.: ews101, ews102, ews106, ews107, ews112, ews113, ews115, ews121, ews122, ews124) got stuck while running tests on this patch. Last log on bots: Running: webkit-patch --status-host=webkit-queues.webkit.org --bot-id=ews121 build-and-test --no-clean --no-update --test --non-interactive --build-style=release --group=None --port=ios-simulator-wk2
Matt Lewis
Comment 5 2017-10-10 11:31:06 PDT
When the windows EWS bots hit this patch again, it caused them to stop again in the build phase. As such there is no build log created.
Aakash Jain
Comment 6 2017-10-10 11:58:43 PDT
ImageDiff seems to be stuck for few hours on this bot (bot205).
Alexey Proskuryakov
Comment 7 2017-10-10 14:05:32 PDT
Tracking the EWS issue as <rdar://problem/34917666>.
zalan
Comment 8 2017-11-15 21:48:48 PST
Created attachment 327049 [details] Patch
zalan
Comment 9 2017-11-16 10:28:54 PST
Created attachment 327081 [details] Patch
Antti Koivisto
Comment 10 2017-11-16 11:06:04 PST
Comment on attachment 327081 [details] Patch Nice
Antti Koivisto
Comment 11 2017-11-16 11:09:47 PST
Comment on attachment 327081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327081&action=review > Source/WebCore/rendering/RenderBoxModelObject.h:280 > + enum class NormalizeAfterInsertion { No, Yes }; This could use a comment explaining what the values mean.
zalan
Comment 12 2017-11-16 11:42:18 PST
Created attachment 327091 [details] Patch
WebKit Commit Bot
Comment 13 2017-11-16 12:26:04 PST
The commit-queue encountered the following flaky tests while processing attachment 327091 [details]: http/tests/security/cross-origin-xsl-BLOCKED.html bug 51054 (authors: abarth@webkit.org, jochen@chromium.org, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 14 2017-11-16 12:26:41 PST
Comment on attachment 327091 [details] Patch Clearing flags on attachment: 327091 Committed r224933: <https://trac.webkit.org/changeset/224933>
WebKit Commit Bot
Comment 15 2017-11-16 12:26:42 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 16 2017-11-16 12:27:32 PST
<rdar://problem/35595478>
Note You need to log in before you can comment on or make changes to this bug.