RESOLVED FIXED 178005
[Readable Streams API] Implement canCloseOrEnqueue 
https://bugs.webkit.org/show_bug.cgi?id=178005
Summary [Readable Streams API] Implement canCloseOrEnqueue
Romain Bellessort
Reported 2017-10-06 02:59:52 PDT
Implement readabelStreamDefaultControllerCanCloseOrEnqueue function, which has been added to the spec to factorize similar tests that were made at multiple places.
Attachments
Patch (5.11 KB, patch)
2017-10-06 03:48 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews114 for mac-elcapitan (1.83 MB, application/zip)
2017-10-06 05:16 PDT, Build Bot 		no flags
Details
Patch (5.12 KB, patch)
2017-10-06 06:01 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Patch (5.09 KB, patch)
2017-10-09 01:33 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Romain Bellessort
Comment 1 2017-10-06 03:48:21 PDT
Created attachment 323007 [details] Patch
Build Bot
Comment 2 2017-10-06 05:16:19 PDT
Comment on attachment 323007 [details] Patch Attachment 323007 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4780230 New failing tests: workers/wasm-hashset.html
Build Bot
Comment 3 2017-10-06 05:16:20 PDT
Created attachment 323009 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Romain Bellessort
Comment 4 2017-10-06 06:01:30 PDT
Created attachment 323011 [details] Patch
youenn fablet
Comment 5 2017-10-06 08:33:02 PDT
Comment on attachment 323011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323011&action=review This sound ok to me. We loose some precision in the exception messages but I guess this is ok. > Source/WebCore/Modules/streams/ReadableStreamInternals.js:547 > + return false; Maybe we can write this as a one liner?
Romain Bellessort
Comment 6 2017-10-09 01:33:19 PDT
Created attachment 323162 [details] Patch
Romain Bellessort
Comment 7 2017-10-09 05:27:07 PDT
(In reply to youenn fablet from comment #5) > Comment on attachment 323011 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=323011&action=review > > This sound ok to me. > We loose some precision in the exception messages but I guess this is ok. > > > Source/WebCore/Modules/streams/ReadableStreamInternals.js:547 > > + return false; > > Maybe we can write this as a one liner? Thanks, I've changed that in the committed patch.
WebKit Commit Bot
Comment 8 2017-10-09 05:53:14 PDT
Comment on attachment 323162 [details] Patch Clearing flags on attachment: 323162 Committed r223044: <http://trac.webkit.org/changeset/223044>
WebKit Commit Bot
Comment 9 2017-10-09 05:53:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-10-09 05:53:37 PDT
<rdar://problem/34884312>
Note You need to log in before you can comment on or make changes to this bug.