[WinCairo] Add WebKit platform files for wincairo webkit

[Yousuke Kimoto]

Add files under WebKit/Platform for wincairo webkit.

[Yousuke Kimoto]

Created attachment 323014 [details]
[PATCH] WebKit platform files for wincairo webkit

[Anders Carlsson]

I don't think these files have the right copyright headers - there are comments referring to old bugs such as https://bugs.webkit.org/show_bug.cgi?id=47502.

[Yousuke Kimoto]

Created attachment 323641 [details]
[PATCH] WebKit platform files for wincairo webkit

Copyrights which are used in LoggingWin.cpp, ModuleWin.cpp and SharedMemoryWin.cpp are fixed.

[Build Bot]

Attachment 323641 [details] did not pass style-queue:


ERROR: Source/WebKit/PlatformWin.cmake:24:  Alphabetical sorting problem. "Platform/win/LoggingWin.cpp" should be before "Shared/curl/WebCoreArgumentCodersCurl.cpp".  [list/order] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yousuke Kimoto]

Created attachment 323678 [details]
[PATCH] WebKit platform files for wincairo webkit

Fixed a style check error.

[Alex Christensen]

Comment on attachment 323678 [details]
[PATCH] WebKit platform files for wincairo webkit

View in context: https://bugs.webkit.org/attachment.cgi?id=323678&action=review

> Source/WebKit/Platform/win/LoggingWin.cpp:50
> +    return String(buffer.get());

Is buffer null-terminated?  Could we use length here?

[WebKit Commit Bot]

Comment on attachment 323678 [details]
[PATCH] WebKit platform files for wincairo webkit

Clearing flags on attachment: 323678

Committed r223966: <https://trac.webkit.org/changeset/223966>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35569011>