Bug 177995 - Add try-bot button on perf analysis status page.
Summary: Add try-bot button on perf analysis status page.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-05 22:23 PDT by dewei_zhu
Modified: 2017-10-06 00:27 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.84 KB, patch)
2017-10-05 22:24 PDT, dewei_zhu
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2017-10-05 22:23:14 PDT
Add try-bot button on perf analysis status page.
Comment 1 dewei_zhu 2017-10-05 22:24:03 PDT
Created attachment 322991 [details]
Patch
Comment 2 Ryosuke Niwa 2017-10-06 00:26:33 PDT
Comment on attachment 322991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322991&action=review

> Websites/perf.webkit.org/public/v3/pages/analysis-category-toolbar.js:74
> +            .trybot-toolbar {

Rename this to .create-button

> Websites/perf.webkit.org/public/v3/pages/analysis-category-toolbar.js:85
> +                <li><a href="#/analysis/task/create">TryBot</a></li>

Let's label this as "Create" instead.
Comment 3 Ryosuke Niwa 2017-10-06 00:27:18 PDT
Let's just monkey-patch this onto the server instead of svn up'ing everything since we've got a lot of changes since the last time we sync'ed. In fact, we probably need to update the database schema to make it compatible with trunk, and I don't really have a time to do that right now.