RESOLVED FIXED 177989
Web Inspector: Improve setting the default / initial sort of a Table 
https://bugs.webkit.org/show_bug.cgi?id=177989
Summary Web Inspector: Improve setting the default / initial sort of a Table
Joseph Pecoraro
Reported 2017-10-05 20:27:48 PDT
Improve setting the default / initial sort of a Table Its hard / impossible to set the initial sort of a Table. Lets make it easier and better. let table = new Table(identifier, ...); if (!table.sortColumnIdentifier) { table.sortOrder = ...; table.sortColumnIdentifier = ...; } The initialLayout of the table will ensure it displays appropriately.
Attachments
[PATCH] Proposed Fix (3.85 KB, patch)
2017-10-05 20:30 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-10-05 20:30:32 PDT
Created attachment 322980 [details] [PATCH] Proposed Fix I like this approach for setting up the default sort. Its easy to find and not too invasive in code. It probably depends on ordering (ensure columns are added before setting the default sort) but thats a pattern I'm already following and encouraging.
Blaze Burg
Comment 2 2017-10-06 09:10:44 PDT
Comment on attachment 322980 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 3 2017-10-06 09:38:00 PDT
Comment on attachment 322980 [details] [PATCH] Proposed Fix Clearing flags on attachment: 322980 Committed r222983: <http://trac.webkit.org/changeset/222983>
WebKit Commit Bot
Comment 4 2017-10-06 09:38:02 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-10-06 09:39:02 PDT
<rdar://problem/34857354>
Note You need to log in before you can comment on or make changes to this bug.