Bug 177987 - We don't need to clearEmptyObjectStructureForPrototype because JSGlobalObject* is part of the cache's key
Summary: We don't need to clearEmptyObjectStructureForPrototype because JSGlobalObject...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 177907
  Show dependency tree / graph
 
Reported: 2017-10-05 18:58 PDT by Saam Barati
Modified: 2019-05-02 16:18 PDT (History)
15 users (show)

See Also:

Attachments
test EWS (1.16 KB, patch)
2017-10-05 19:11 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (3.59 KB, patch)
2017-10-09 18:47 PDT, Saam Barati 		fpizlo: review+
Details | Formatted Diff | Diff
patch for landing (3.78 KB, patch)
2017-10-09 19:55 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-10-05 18:58:11 PDT 
Going to run some stuff on EWS to see what happens.

Geoff, any idea why we have this? Is it an optimization or needed for correctness?
Comment 1 Saam Barati 2017-10-05 19:11:26 PDT 
Created attachment 322965 [details]
test EWS
Comment 2 Build Bot 2017-10-05 19:12:51 PDT 
Attachment 322965 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/PrototypeMap.cpp:84:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/runtime/PrototypeMap.cpp:85:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2017-10-09 18:47:42 PDT 
Created attachment 323265 [details]
patch
Comment 4 Saam Barati 2017-10-09 19:55:15 PDT 
Created attachment 323271 [details]
patch for landing
Comment 5 WebKit Commit Bot 2017-10-09 22:11:31 PDT 
Comment on attachment 323271 [details]
patch for landing

Clearing flags on attachment: 323271

Committed r223123: <http://trac.webkit.org/changeset/223123>
Comment 6 WebKit Commit Bot 2017-10-09 22:11:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-09 22:12:08 PDT 
<rdar://problem/34903593>