177983 – Add basic support for getting a ImageBitmapRenderingContext

Bug 177983 - Add basic support for getting a ImageBitmapRenderingContext

Summary: Add basic support for getting a ImageBitmapRenderingContext

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Sam Weinig

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2017-10-05 17:42 PDT by Sam Weinig
Modified:	2017-10-06 14:30 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (40.26 KB, patch) 2017-10-05 17:48 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (40.26 KB, patch) 2017-10-05 17:59 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (42.13 KB, patch) 2017-10-05 20:22 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (42.19 KB, patch) 2017-10-05 20:58 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (42.18 KB, patch) 2017-10-05 21:10 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (42.55 KB, patch) 2017-10-05 21:19 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (44.96 KB, patch) 2017-10-06 02:56 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (44.23 KB, patch) 2017-10-06 03:33 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (44.52 KB, patch) 2017-10-06 07:35 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (61.24 KB, patch) 2017-10-06 11:40 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam Weinig 2017-10-05 17:42:54 PDT

Add basic support for getting a ImageBitmapRenderingContext

Comment 1 Sam Weinig 2017-10-05 17:48:00 PDT Comment hidden (obsolete)

Created attachment 322951 [details]
Patch

Comment 2 Build Bot 2017-10-05 17:49:08 PDT Comment hidden (obsolete)

Attachment 322951 [details] did not pass style-queue:


ERROR: Source/WebCore/html/canvas/PlaceholderRenderingContext.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Sam Weinig 2017-10-05 17:59:09 PDT Comment hidden (obsolete)

Created attachment 322954 [details]
Patch

Comment 4 Build Bot 2017-10-05 18:01:54 PDT Comment hidden (obsolete)

Attachment 322954 [details] did not pass style-queue:


ERROR: Source/WebCore/html/canvas/PlaceholderRenderingContext.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Sam Weinig 2017-10-05 20:22:57 PDT Comment hidden (obsolete)

Created attachment 322979 [details]
Patch

Comment 6 Build Bot 2017-10-05 20:24:06 PDT Comment hidden (obsolete)

Attachment 322979 [details] did not pass style-queue:


ERROR: Source/WebCore/html/canvas/PlaceholderRenderingContext.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Sam Weinig 2017-10-05 20:58:29 PDT Comment hidden (obsolete)

Created attachment 322982 [details]
Patch

Comment 8 Build Bot 2017-10-05 21:01:02 PDT Comment hidden (obsolete)

Attachment 322982 [details] did not pass style-queue:


ERROR: Source/WebCore/html/canvas/PlaceholderRenderingContext.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Sam Weinig 2017-10-05 21:10:33 PDT Comment hidden (obsolete)

Created attachment 322983 [details]
Patch

Comment 10 Build Bot 2017-10-05 21:12:00 PDT Comment hidden (obsolete)

Attachment 322983 [details] did not pass style-queue:


ERROR: Source/WebCore/html/canvas/PlaceholderRenderingContext.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 11 Sam Weinig 2017-10-05 21:19:50 PDT Comment hidden (obsolete)

Created attachment 322984 [details]
Patch

Comment 12 Sam Weinig 2017-10-06 02:56:46 PDT Comment hidden (obsolete)

Created attachment 323004 [details]
Patch

Comment 13 Sam Weinig 2017-10-06 03:33:06 PDT Comment hidden (obsolete)

Created attachment 323006 [details]
Patch

Comment 14 Sam Weinig 2017-10-06 07:35:53 PDT Comment hidden (obsolete)

Created attachment 323015 [details]
Patch

Comment 15 Sam Weinig 2017-10-06 11:40:45 PDT

Created attachment 323033 [details]
Patch

Comment 16 WebKit Commit Bot 2017-10-06 14:29:05 PDT

Comment on attachment 323033 [details]
Patch

Clearing flags on attachment: 323033

Committed r222997: <http://trac.webkit.org/changeset/222997>

Comment 17 WebKit Commit Bot 2017-10-06 14:29:06 PDT

All reviewed patches have been landed.  Closing bug.

Comment 18 Radar WebKit Bug Importer 2017-10-06 14:30:43 PDT

<rdar://problem/34864336>