Bug 177970 - Win EWS bots should reboot after N webkit-patch iterations.
Summary: Win EWS bots should reboot after N webkit-patch iterations.
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-05 14:49 PDT by Per Arne Vollan
Modified: 2018-01-26 09:16 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.32 KB, patch)
2017-10-05 14:51 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-10-05 14:49:19 PDT 
I believe the macOS EWS bots reboot after webkit-patch has processed N patches.
Comment 1 Per Arne Vollan 2017-10-05 14:51:36 PDT 
Created attachment 322920 [details]
Patch
Comment 2 Ryan Haddad 2017-10-05 15:09:26 PDT 
I know we have seen Windows EWS bots require a manual log in before coming back online in the past. Do we think this will still be an issue?
Comment 3 Per Arne Vollan 2017-10-05 15:16:09 PDT 
(In reply to Ryan Haddad from comment #2)
> I know we have seen Windows EWS bots require a manual log in before coming
> back online in the past. Do we think this will still be an issue?

I believe we have fixed this by enabling auto-login again.
Comment 4 Ryan Haddad 2017-10-05 16:05:38 PDT 
(In reply to Per Arne Vollan from comment #3)
> (In reply to Ryan Haddad from comment #2)
> > I know we have seen Windows EWS bots require a manual log in before coming
> > back online in the past. Do we think this will still be an issue?
> 
> I believe we have fixed this by enabling auto-login again.
Ah, that would do it. 

I made this change for the macOS EWS bots to try to prevent them from getting into weird states with stuck processes. If we think the reboots benefit Windows EWS, this looks good to me.
Comment 5 Ryan Haddad 2017-11-13 17:22:13 PST 
I hit a case today where a Windows EWS bot needed 'svn cleanup' to be run. This change would have allowed the bot to recover itself after a few more runs without my intervention.

Any reviewers willing to r+ this?
Comment 6 Brent Fulgham 2017-11-13 18:42:37 PST 
Comment on attachment 322920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322920&action=review

> Tools/ChangeLog:3
> +        Win EWS bots should reboot after N webkit-patch iterations.

It looks like N in this case is 1.

If you think EWS will keep up with the change, r=me
Comment 7 Per Arne Vollan 2017-11-16 07:32:52 PST 
Comment on attachment 322920 [details]
Patch

Thanks for reviewing!
Comment 8 WebKit Commit Bot 2017-11-16 07:52:32 PST 
Comment on attachment 322920 [details]
Patch

Clearing flags on attachment: 322920

Committed r224920: <https://trac.webkit.org/changeset/224920>
Comment 9 WebKit Commit Bot 2017-11-16 07:52:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-11-16 07:53:16 PST 
<rdar://problem/35588672>
Comment 11 Per Arne Vollan 2018-01-26 09:16:33 PST 
Rolled out in <https://trac.webkit.org/changeset/227679/webkit>. Some EWS bots are not coming back online after initiating reboot.