This will help catch regressions at an early stage.
<rdar://problem/22918746>
Created attachment 322915 [details] Patch
Comment on attachment 322915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322915&action=review > Tools/Scripts/webkitpy/common/config/ews.json:13 > + "runTests": true Do we have enough hardware set up for Windows EWS already?
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 322915 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322915&action=review > > > Tools/Scripts/webkitpy/common/config/ews.json:13 > > + "runTests": true > > Do we have enough hardware set up for Windows EWS already? Yes, I believe so, although it wouldn't hurt to get more :) I think I overestimated the extra time this would add to the total processing time. It adds 10-12 minutes for each EWS pass.
I see. Leaving this for Lucas to r+, and to face the consequences :)
(In reply to Alexey Proskuryakov from comment #5) > I see. Leaving this for Lucas to r+, and to face the consequences :) Sounds good :) Thanks!
I spoke with Alexey this morning. We discussed moving all Windows EWS bots to SSDs before turning this on. I’ll be tracking that in <rdar://problem/34891365> Check EWS hardware, find units that need SSD
(In reply to Lucas Forschler from comment #7) > I spoke with Alexey this morning. We discussed moving all Windows EWS bots > to SSDs before turning this on. > > I’ll be tracking that in > <rdar://problem/34891365> Check EWS hardware, find units that need SSD Great, thank you!
Comment on attachment 322915 [details] Patch Clearing flags on attachment: 322915 Committed r228383: <https://trac.webkit.org/changeset/228383>
All reviewed patches have been landed. Closing bug.