RESOLVED FIXED 177967
EWS should run Windows tests. 
https://bugs.webkit.org/show_bug.cgi?id=177967
Summary EWS should run Windows tests.
Per Arne Vollan
Reported 2017-10-05 14:15:14 PDT
This will help catch regressions at an early stage.
Attachments
Patch (1.08 KB, patch)
2017-10-05 14:18 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2017-10-05 14:17:13 PDT
<rdar://problem/22918746>
Per Arne Vollan
Comment 2 2017-10-05 14:18:52 PDT
Created attachment 322915 [details] Patch
Alexey Proskuryakov
Comment 3 2017-10-06 10:16:33 PDT
Comment on attachment 322915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322915&action=review > Tools/Scripts/webkitpy/common/config/ews.json:13 > + "runTests": true Do we have enough hardware set up for Windows EWS already?
Per Arne Vollan
Comment 4 2017-10-06 10:28:49 PDT
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 322915 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322915&action=review > > > Tools/Scripts/webkitpy/common/config/ews.json:13 > > + "runTests": true > > Do we have enough hardware set up for Windows EWS already? Yes, I believe so, although it wouldn't hurt to get more :) I think I overestimated the extra time this would add to the total processing time. It adds 10-12 minutes for each EWS pass.
Alexey Proskuryakov
Comment 5 2017-10-06 15:34:30 PDT
I see. Leaving this for Lucas to r+, and to face the consequences :)
Per Arne Vollan
Comment 6 2017-10-06 16:16:01 PDT
(In reply to Alexey Proskuryakov from comment #5) > I see. Leaving this for Lucas to r+, and to face the consequences :) Sounds good :) Thanks!
Lucas Forschler
Comment 7 2017-10-09 13:32:42 PDT
I spoke with Alexey this morning. We discussed moving all Windows EWS bots to SSDs before turning this on. I’ll be tracking that in <rdar://problem/34891365> Check EWS hardware, find units that need SSD
Per Arne Vollan
Comment 8 2017-10-09 16:20:59 PDT
(In reply to Lucas Forschler from comment #7) > I spoke with Alexey this morning. We discussed moving all Windows EWS bots > to SSDs before turning this on. > > I’ll be tracking that in > <rdar://problem/34891365> Check EWS hardware, find units that need SSD Great, thank you!
WebKit Commit Bot
Comment 9 2018-02-12 10:44:04 PST
Comment on attachment 322915 [details] Patch Clearing flags on attachment: 322915 Committed r228383: <https://trac.webkit.org/changeset/228383>
WebKit Commit Bot
Comment 10 2018-02-12 10:44:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.