RESOLVED FIXED 177955
AX: [ATK] Explicitly-set aria-sort value of "none" should be exposed as an object attribute
https://bugs.webkit.org/show_bug.cgi?id=177955
Summary AX: [ATK] Explicitly-set aria-sort value of "none" should be exposed as an ob...
Joanmarie Diggs
Reported 2017-10-05 11:22:06 PDT
Currently we are not exposing the aria-sort value when it is "none", but the Core AAM states that when the value is none and has been explicitly set, we should expose it.
Attachments
Patch (8.12 KB, patch)
2017-10-05 11:29 PDT, Joanmarie Diggs
no flags
Archive of layout-test-results from ews102 for mac-elcapitan (1.23 MB, application/zip)
2017-10-05 12:34 PDT, Build Bot
no flags
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.69 MB, application/zip)
2017-10-05 12:50 PDT, Build Bot
no flags
Patch (9.30 KB, patch)
2017-10-05 13:02 PDT, Joanmarie Diggs
no flags
Radar WebKit Bug Importer
Comment 1 2017-10-05 11:22:43 PDT
Joanmarie Diggs
Comment 2 2017-10-05 11:29:00 PDT
chris fleizach
Comment 3 2017-10-05 11:45:16 PDT
Comment on attachment 322867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322867&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:513 > + if (sortDirection != SortDirectionInvalid && coreObject->hasAttribute(HTMLNames::aria_sortAttr)) { can you use a switch statement here. should be a bit cleaner
Joanmarie Diggs
Comment 4 2017-10-05 12:22:49 PDT
(In reply to chris fleizach from comment #3) > Comment on attachment 322867 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322867&action=review > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:513 > > + if (sortDirection != SortDirectionInvalid && coreObject->hasAttribute(HTMLNames::aria_sortAttr)) { > > can you use a switch statement here. should be a bit cleaner Will do. Waiting to get the test failures for your platform out of EWS (traveling, and thus away from my Mac).
Build Bot
Comment 5 2017-10-05 12:34:08 PDT
Comment on attachment 322867 [details] Patch Attachment 322867 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4770595 New failing tests: accessibility/plugin.html accessibility/mac/bounds-for-range.html accessibility/image-link.html accessibility/mac/internal-link-anchors.html accessibility/internal-link-anchors2.html accessibility/mac/document-links.html accessibility/table-with-rules.html accessibility/mac/document-attributes.html accessibility/table-one-cell.html accessibility/table-sections.html accessibility/table-cells.html accessibility/image-map2.html accessibility/table-cell-spans.html accessibility/table-attributes.html accessibility/transformed-element.html accessibility/math-multiscript-attributes.html accessibility/parent-delete.html accessibility/lists.html
Build Bot
Comment 6 2017-10-05 12:34:09 PDT
Created attachment 322883 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 7 2017-10-05 12:50:27 PDT
Comment on attachment 322867 [details] Patch Attachment 322867 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4770734 New failing tests: accessibility/plugin.html accessibility/mac/bounds-for-range.html accessibility/image-link.html accessibility/parent-delete.html accessibility/mac/internal-link-anchors.html accessibility/mac/document-links.html accessibility/table-with-rules.html accessibility/math-multiscript-attributes.html accessibility/table-one-cell.html accessibility/transformed-element.html accessibility/table-cells.html accessibility/table-sections.html accessibility/table-cell-spans.html accessibility/lists.html accessibility/table-attributes.html accessibility/mac/document-attributes.html accessibility/internal-link-anchors2.html accessibility/image-map2.html
Build Bot
Comment 8 2017-10-05 12:50:28 PDT
Created attachment 322884 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Joanmarie Diggs
Comment 9 2017-10-05 13:02:09 PDT
WebKit Commit Bot
Comment 10 2017-10-09 10:12:38 PDT
Comment on attachment 322887 [details] Patch Clearing flags on attachment: 322887 Committed r223048: <http://trac.webkit.org/changeset/223048>
WebKit Commit Bot
Comment 11 2017-10-09 10:12:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.