WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
177954
AX: [iOS] Layout Test accessibility/ios-simulator/video-elements-ios.html is failing
https://bugs.webkit.org/show_bug.cgi?id=177954
Summary
AX: [iOS] Layout Test accessibility/ios-simulator/video-elements-ios.html is ...
Nan Wang
Reported
2017-10-05 11:12:32 PDT
The following layout test is failing on [iOS] accessibility/ios-simulator/video-elements-ios.html
Attachments
patch
(3.05 KB, patch)
2017-10-05 11:50 PDT
,
Nan Wang
no flags
Details
Formatted Diff
Diff
patch
(1.73 KB, patch)
2017-10-06 11:08 PDT
,
Nan Wang
no flags
Details
Formatted Diff
Diff
patch
(1.73 KB, patch)
2017-10-06 11:22 PDT
,
Nan Wang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-10-05 11:13:04 PDT
<
rdar://problem/34838094
>
Nan Wang
Comment 2
2017-10-05 11:50:45 PDT
Created
attachment 322876
[details]
patch Fixed the test
Ryan Haddad
Comment 3
2017-10-05 13:38:49 PDT
Comment on
attachment 322876
[details]
patch Marking CQ+ to get this landed since the test failures is affecting EWS results.
WebKit Commit Bot
Comment 4
2017-10-05 14:07:17 PDT
Comment on
attachment 322876
[details]
patch Clearing flags on attachment: 322876 Committed
r222931
: <
http://trac.webkit.org/changeset/222931
>
WebKit Commit Bot
Comment 5
2017-10-05 14:07:19 PDT
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 6
2017-10-06 10:33:33 PDT
This patch fixed the consistent failure, however it is now become a flaky timeout.
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fios-simulator%2Fvideo-elements-ios.html
build:
https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r222978%20(369)/results.html
https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/369
Diff: --- /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/accessibility/ios-simulator/video-elements-ios-expected.txt +++ /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/accessibility/ios-simulator/video-elements-ios-actual.txt @@ -1,19 +1,5 @@ - -This tests the video elements on iOS. +#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 68297) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS video.isIgnored is false -PASS video2.isIgnored is true -PASS video.description is 'AXLabel: Video label1, 9 seconds' -PASS video.stringValue is 'AXValue: 0 seconds' -PASS vid.paused is true -PASS vid.paused is false -PASS vid.paused is true -PASS video.stringValue is 'AXValue: 2 seconds' -PASS video.stringValue is 'AXValue: 1 seconds' -PASS successfullyParsed is true - -TEST COMPLETE - +#EOF +#EOF This is causing problems on EWS. If its something that can't be fixed quickly, I'd like to roll out both patches.
Nan Wang
Comment 7
2017-10-06 10:35:34 PDT
Please don't roll out the patches. I will disable the test for now while looking into it further
Nan Wang
Comment 8
2017-10-06 11:08:10 PDT
Created
attachment 323028
[details]
patch I think the problem is that sometimes the video element has triggered the canplaythrough event before we registered the event handler.
Nan Wang
Comment 9
2017-10-06 11:21:44 PDT
Reopen the bug
Nan Wang
Comment 10
2017-10-06 11:22:38 PDT
Created
attachment 323031
[details]
patch patch
WebKit Commit Bot
Comment 11
2017-10-06 14:41:05 PDT
Comment on
attachment 323031
[details]
patch Clearing flags on attachment: 323031 Committed
r222999
: <
http://trac.webkit.org/changeset/222999
>
WebKit Commit Bot
Comment 12
2017-10-06 14:41:06 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug