Bug 177947 – [Cairo] Create Cairo patterns from Gradient objects on-the-fly

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[Cairo] Create Cairo patterns from Gradient objects on-the-fly

[Zan Dobersek]

Created attachment 322843 [details]
Patch

[Build Bot]

Comment on attachment 322843 [details]
Patch

Attachment 322843 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4768940

New failing tests:
accessibility/ios-simulator/video-elements-ios.html

[Build Bot]

Created attachment 322864 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Carlos Garcia Campos]

Comment on attachment 322843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322843&action=review

> Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:82
> -    cairo_t* cr = context->platformContext()->cr();
> +    RefPtr<cairo_pattern_t> gradient(adoptRef(createPlatformGradient(1.0)));

We normally use = with adoptRef().

> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:276
> +        RefPtr<cairo_pattern_t> cairoPattern(adoptRef(gradient->createPlatformGradient(globalAlpha)));

Ditto.

[Zan Dobersek]

Committed r222975: <http://trac.webkit.org/changeset/222975>

[Radar WebKit Bug Importer]

<rdar://problem/34853440>