Bug 177931 – AX: [ATK] STATE_CHECKABLE should be removed from radio buttons in radiogroups with aria-readonly="true"

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

Radio buttons in a readonly ARIA radiogroup should not claim to be settable/checkable, as per the Core AAM:
https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaReadonlyTrue

[Radar WebKit Bug Importer]

<rdar://problem/34831213>

[Joanmarie Diggs]

Created attachment 322820 [details]
Patch

[chris fleizach]

Comment on attachment 322820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322820&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:2107
> +        return radioGroup ? radioGroup->ariaReadOnlyValue() != "true" : true;

do we want to do equalIgnoringCase() for the != true

[Joanmarie Diggs]

(In reply to chris fleizach from comment #3)
> Comment on attachment 322820 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322820&action=review
> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:2107
> > +        return radioGroup ? radioGroup->ariaReadOnlyValue() != "true" : true;
> 
> do we want to do equalIgnoringCase() for the != true

In this case I don't believe it is necessary: ariaReadOnlyValue() applies convertToASCIILowercase() to the value being returned.

[WebKit Commit Bot]

Comment on attachment 322820 [details]
Patch

Clearing flags on attachment: 322820

Committed r223126: <http://trac.webkit.org/changeset/223126>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.