Bug 177930 – Layout Test media/modern-media-controls/scrubber-support/scrubber-support-click.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

The following layout test is flaky on Apple Sierra Debug WK1

media/modern-media-controls/scrubber-support/scrubber-support-click.html

[Antoine Quint]

Created attachment 322819 [details]
Patch

[Dean Jackson]

Comment on attachment 322819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322819&action=review

> LayoutTests/ChangeLog:10
> +        In cases where this test failed, it actually worked as expected but the "timeupdate" event would be fired
> +        twice, most likely because it was registered twice. We now use an asynchronous expectation to run the test
> +        which should only register the event listener once and make the test more reliable.

You could probably just pass in a { once: true } to the event listener registration. Or are you saying it was actually registered twice?

[Antoine Quint]

(In reply to Dean Jackson from comment #2)
> Comment on attachment 322819 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322819&action=review
> 
> > LayoutTests/ChangeLog:10
> > +        In cases where this test failed, it actually worked as expected but the "timeupdate" event would be fired
> > +        twice, most likely because it was registered twice. We now use an asynchronous expectation to run the test
> > +        which should only register the event listener once and make the test more reliable.
> 
> You could probably just pass in a { once: true } to the event listener
> registration. Or are you saying it was actually registered twice?

It was registered twice.

[WebKit Commit Bot]

Comment on attachment 322819 [details]
Patch

Clearing flags on attachment: 322819

Committed r222923: <http://trac.webkit.org/changeset/222923>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34839329>