Bug 177927 - Evaluate the cost of VERBOSE_LOG() in the DFGByteCodeParser
Summary: Evaluate the cost of VERBOSE_LOG() in the DFGByteCodeParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords:
Depends on: 177922
Blocks:
  Show dependency tree / graph
 
Reported: 2017-10-05 03:00 PDT by Robin Morisset
Modified: 2017-10-09 16:41 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2017-10-05 03:00:01 PDT 
It is probably not significant since it is a perfectly predictable branch, but it should be measured nonetheless.
If the cost of the comparison on every call to VERBOSE_LOG() turns out not to be negligible, the macro should probably be modified to be a no-op in release mode.
Comment 1 Robin Morisset 2017-10-09 16:41:23 PDT 
After discussing it with Saam, I eventually decided to just make VERBOSE_LOG a no_op in release mode by default, with an easy way to change it. See https://bugs.webkit.org/show_bug.cgi?id=177922 for details.