Bug 177914 – Web Inspector: When scrolled Network Table reduces the number of rows it may appear as blank

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

When scrolled Network Table reduces the number of rows it may appear as blank

Steps to Reproduce:
1. Inspect apple.com
2. Show Network Tab
3. Reload
4. Scroll Network Tab Down
5. Select "Document" filter
  => expected to see 1 Document resource, instead see blank / broken table

Notes:
• The number of rows was reduced, but the Table's scrollTop was not reset to a reasonable value. This can happen any time the row count goes down so we should have a generic solution.

[Radar WebKit Bug Importer]

<rdar://problem/34827613>

[Joseph Pecoraro]

Created attachment 322777 [details]
[PATCH] Proposed Fix

[Matt Baker]

Comment on attachment 322777 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=322777&action=review

r=me, with (optional) nits.

> Source/WebInspectorUI/UserInterface/Views/Table.js:897
> +        if (this._cachedScrollTop) {

Might as well use scrollTop from above, since scrollableOffsetHeight is used.

> Source/WebInspectorUI/UserInterface/Views/Table.js:901
> +                if (this._cachedScrollTop > maximumScrollTop) {

Ditto.

> Source/WebInspectorUI/UserInterface/Views/Table.js:950
> +        // of rows can fit on screen. Reset the scroll top.

Should this say "Reset the scroll top to zero", so that it's obvious that we didn't mean to set it to NaN?

[Joseph Pecoraro]

Created attachment 322787 [details]
[PATCH] For Landing

[WebKit Commit Bot]

Comment on attachment 322787 [details]
[PATCH] For Landing

Clearing flags on attachment: 322787

Committed r222899: <http://trac.webkit.org/changeset/222899>