Bug 177906 – Update WebKit Code Style with Objective-C block syntax guidelines

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Update Webkit Style webpage to include Obj-C blocks

[Megan Gardner]

Created attachment 322746 [details]
Patch

[Wenson Hsieh]

Comment on attachment 322746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322746&action=review

> Websites/webkit.org/code-style.md:237
> +[](#spacing-function-paren) In Objective-C, do not place spaces between the start of a block and its aguments, or start of a block and its opening brace.

"aguments" => "arguments"

"or start of" => "or the start of"

> Websites/webkit.org/code-style.md:259
> +block = ^ (int, int) {

Hm...it seems official Apple style documentation uses this style: <https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html#//apple_ref/doc/uid/TP40011210-CH8-SW2>. I see both spaces before and after the parens (like `^ (double firstValue, double secondValue) {`) and also spaces only after the end paren (like `^(double firstValue, double secondValue) {`), but not an example of both spaces being omitted.

[Megan Gardner]

Comment on attachment 322746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322746&action=review

>> Websites/webkit.org/code-style.md:259
>> +block = ^ (int, int) {
> 
> Hm...it seems official Apple style documentation uses this style: <https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html#//apple_ref/doc/uid/TP40011210-CH8-SW2>. I see both spaces before and after the parens (like `^ (double firstValue, double secondValue) {`) and also spaces only after the end paren (like `^(double firstValue, double secondValue) {`), but not an example of both spaces being omitted.

Oh, I looked at that over and over, and I reduced it incorrectly, thank you. I'll redo this.

[Megan Gardner]

Created attachment 322764 [details]
Patch

[Build Bot]

Comment on attachment 322764 [details]
Patch

Attachment 322764 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4761808

New failing tests:
accessibility/ios-simulator/video-elements-ios.html

[Build Bot]

Created attachment 322770 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Megan Gardner]

https://trac.webkit.org/changeset/222935/webkit

[Radar WebKit Bug Importer]

<rdar://problem/34844976>