Bug 177898 - Move multicolumn flow clear to RenderTreeUpdater
Summary: Move multicolumn flow clear to RenderTreeUpdater
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-04 14:03 PDT by zalan
Modified: 2017-10-05 07:04 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.03 KB, patch)
2017-10-04 14:34 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.49 MB, application/zip)
2017-10-04 16:23 PDT, Build Bot
no flags Details
Patch (7.47 KB, patch)
2017-10-04 21:29 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-04 14:03:10 PDT
the set() is there to.
Comment 1 Radar WebKit Bug Importer 2017-10-04 14:03:46 PDT
<rdar://problem/34820157>
Comment 2 zalan 2017-10-04 14:34:30 PDT
Created attachment 322728 [details]
Patch
Comment 3 Build Bot 2017-10-04 16:23:56 PDT
Comment on attachment 322728 [details]
Patch

Attachment 322728 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4758808

New failing tests:
fast/multicol/span/list-multi-column-crash.html
fast/multicol/span/empty-anonymous-block-split-crash.html
fast/multicol/body-stuck-with-dirty-bit-with-columns.html
fast/multicol/orphans-relayout.html
fast/multicol/vertical-rl/image-inside-nested-blocks-with-border.html
fast/multicol/content-bounding-box-rtl.html
fast/multicol/multicol-transform-containing-block.html
fast/multicol/vertical-lr/image-inside-nested-blocks-with-border.html
fast/multicol/float-truncation.html
fast/multicol/image-inside-nested-blocks-with-border.html
fast/multicol/newmulticol/multicol-inside-multicol.html
fast/block/block-remove-child-delete-line-box-crash.html
imported/blink/fast/block/multicol-paint-invalidation-assert.html
fast/multicol/widows-and-orphans.html
imported/blink/fast/lists/list-inside-columns-crash.html
fast/dom/Element/getClientRects.html
fast/multicol/anonymous-block-split-crash.html
fast/css/getComputedStyle/getComputedStyle-length-unit.html
fast/multicol/vertical-lr/float-truncation.html
fast/multicol/vertical-rl/float-truncation.html
Comment 4 Build Bot 2017-10-04 16:23:58 PDT
Created attachment 322737 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 5 zalan 2017-10-04 21:29:41 PDT
Created attachment 322776 [details]
Patch
Comment 6 WebKit Commit Bot 2017-10-05 07:04:31 PDT
Comment on attachment 322776 [details]
Patch

Clearing flags on attachment: 322776

Committed r222911: <http://trac.webkit.org/changeset/222911>
Comment 7 WebKit Commit Bot 2017-10-05 07:04:33 PDT
All reviewed patches have been landed.  Closing bug.