Check webkit style throws an error when you do not put a space between the ^ and the { for objective-c blocks. It was made so with the changes for this bug: https://bugs.webkit.org/show_bug.cgi?id=161247 But there is agreement that this should not be the case, and a space should not be required. A vast majority of the code in webkit already conforms to this style, with only a few outliers.
Created attachment 322730 [details] Patch
I need to expand this, new patch forthcoming
Created attachment 322732 [details] Patch
If you look at comment 5 in <https://bugs.webkit.org/show_bug.cgi?id=161247>, I specifically call out the problem Megan is addressing here... I'm not an Objective C programmer, and the WebKit style guide gives some conflicting advice on this. This seems like the right change, especially since you've seemed agreement with others more familiar than I with Objective C style.
Created attachment 322739 [details] Patch
Comment on attachment 322739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322739&action=review Unofficial R+, but please edit the ChangeLog to reflect the new behavior > Tools/ChangeLog:8 > + Remove the check for a space between ^ and {, To clarify, this change does the opposite of the original code, right? Now the style checker will enforce that there is NOT a space between ^ and { in an objective-C block.
Comment on attachment 322739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322739&action=review > Tools/ChangeLog:3 > + check-webkit-style erroneously requires a space between the carrot and brace in obj-c blocks. Blocks are not specific to Objective-C. https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html > Tools/Scripts/webkitpy/style/checkers/cpp.py:1265 > + if search(r'\^\s\{', group): Would it make sense to check for one or more space characters, \s+? If so, please add additional tests.
https://trac.webkit.org/r222937
<rdar://problem/34845080>