Bug 177865 - [JHBuild][GTK][WKE] Circular dependency between harfbuzz and freetype6
Summary: [JHBuild][GTK][WKE] Circular dependency between harfbuzz and freetype6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-04 04:22 PDT by Carlos Alberto Lopez Perez
Modified: 2017-10-04 09:57 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.39 KB, patch)
2017-10-04 04:31 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (3.39 KB, patch)
2017-10-04 07:35 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-10-04 04:22:03 PDT
On the JHBuild for the GTK+ and WPE ports we are building both harfbuzz and freetype6.

The issue is that there is a circular dependency between harfbuzz and freetype6 that can cause issues depending on what the libraries the developer has installed.

This is because the switch to detect this features is automatic enabled depending on the headers it detects.

The support for harfbuzz on freetype6 is an optional feature that most distros (fedora, debian, openembedded....) seems to disable by building freetype6 with --with-harfbuzz=no


Let's do the same
Comment 1 Carlos Alberto Lopez Perez 2017-10-04 04:31:13 PDT
Created attachment 322652 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2017-10-04 07:35:04 PDT
Created attachment 322668 [details]
Patch

Re-EWS
Comment 3 WebKit Commit Bot 2017-10-04 09:00:02 PDT
The commit-queue encountered the following flaky tests while processing attachment 322668 [details]:

The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2017-10-04 09:00:12 PDT
The commit-queue encountered the following flaky tests while processing attachment 322668 [details]:

media/modern-media-controls/seek-backward-support/seek-backward-support.html bug 174916 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2017-10-04 09:54:20 PDT
Comment on attachment 322668 [details]
Patch

Clearing flags on attachment: 322668

Committed r222851: <http://trac.webkit.org/changeset/222851>
Comment 6 WebKit Commit Bot 2017-10-04 09:54:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-04 09:57:19 PDT
<rdar://problem/34813726>