177849 – Add missing exception checks and book-keeping to pass exception check validation for LayoutTests/js tests.

ASSIGNED 177849

Add missing exception checks and book-keeping to pass exception check validation for LayoutTests/js tests.

https://bugs.webkit.org/show_bug.cgi?id=177849

Summary Add missing exception checks and book-keeping to pass exception check validat...

Mark Lam

Reported 2017-10-03 17:40:40 PDT

Patch coming soon.

Attachments
work in progress. (82.58 KB, patch) 2017-10-03 18:02 PDT, Mark Lam	no flags	Details Formatted Diff Diff
proposed patch. (89.64 KB, patch) 2017-10-04 16:32 PDT, Mark Lam	mark.lam: review-	Details Formatted Diff Diff
proposed patch. (328.86 KB, patch) 2017-10-04 16:49 PDT, Mark Lam	mark.lam: review- buildbot: commit-queue-	Details Formatted Diff Diff
proposed patch. (342.49 KB, patch) 2017-10-04 17:45 PDT, Mark Lam	buildbot: commit-queue-	Details Formatted Diff Diff
proposed patch. (351.98 KB, patch) 2017-10-04 18:00 PDT, Mark Lam	no flags	Details Formatted Diff Diff
proposed patch. (352.18 KB, patch) 2017-10-04 18:12 PDT, Mark Lam	buildbot: commit-queue-	Details Formatted Diff Diff
proposed patch. (352.67 KB, patch) 2017-10-04 18:21 PDT, Mark Lam	no flags	Details Formatted Diff Diff
proposed patch. (352.68 KB, patch) 2017-10-04 18:36 PDT, Mark Lam	no flags	Details Formatted Diff Diff
proposed patch: one more time (hopefully this is it). (352.69 KB, patch) 2017-10-04 18:56 PDT, Mark Lam	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.04 MB, application/zip) 2017-10-04 20:16 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.13 MB, application/zip) 2017-10-04 20:24 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.09 MB, application/zip) 2017-10-04 20:25 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.92 MB, application/zip) 2017-10-04 20:42 PDT, Build Bot	no flags	Details
proposed patch: rebased. (352.88 KB, patch) 2017-10-18 11:34 PDT, Mark Lam	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.10 MB, application/zip) 2017-10-18 12:56 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.48 MB, application/zip) 2017-10-18 12:58 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.92 MB, application/zip) 2017-10-18 13:13 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (5.21 MB, application/zip) 2017-10-18 13:29 PDT, Build Bot	no flags	Details
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-10-03 17:41:31 PDT

<rdar://problem/34803702>

Mark Lam

Comment 2 2017-10-03 18:02:26 PDT

Created attachment 322621 [details] work in progress.

Mark Lam

Comment 3 2017-10-04 16:32:16 PDT

Created attachment 322738 [details] proposed patch.

Mark Lam

Comment 4 2017-10-04 16:34:28 PDT

Comment on attachment 322738 [details] proposed patch. Will re-base again.

Mark Lam

Comment 5 2017-10-04 16:49:52 PDT

Created attachment 322741 [details] proposed patch.

Build Bot

Comment 6 2017-10-04 16:53:55 PDT

Comment on attachment 322741 [details] proposed patch. Attachment 322741 [details] did not pass bindings-ews (mac): Output: http://webkit-queues.webkit.org/results/4759653 New failing tests: (JS) JSTestSerialization.cpp (JS) JSTestSerializationInherit.cpp (JS) JSTestSerializationInheritFinal.cpp (JS) JSTestSerializedScriptValueInterface.cpp (JS) JSTestStandaloneDictionary.cpp (JS) JSTestStringifier.cpp (JS) JSTestStringifierAnonymousOperation.cpp (JS) JSTestStringifierNamedOperation.cpp (JS) JSTestStringifierOperationImplementedAs.cpp (JS) JSTestStringifierOperationNamedToString.cpp (JS) JSTestStringifierReadOnlyAttribute.cpp (JS) JSTestStringifierReadWriteAttribute.cpp (JS) JSTestTypedefs.cpp (JS) JSTestVoidCallbackFunction.cpp

Mark Lam

Comment 7 2017-10-04 17:17:56 PDT

Comment on attachment 322741 [details] proposed patch. I'll fix the remaining issues. Looks like I also need to do a full release build before rebasing the bindings test results.

Mark Lam

Comment 8 2017-10-04 17:45:11 PDT

Created attachment 322750 [details] proposed patch.

Build Bot

Comment 9 2017-10-04 17:49:15 PDT

Comment on attachment 322750 [details] proposed patch. Attachment 322750 [details] did not pass bindings-ews (mac): Output: http://webkit-queues.webkit.org/results/4760414 New failing tests: (JS) JSTestTypedefs.cpp (JS) JSTestVoidCallbackFunction.cpp

Mark Lam

Comment 10 2017-10-04 18:00:07 PDT

Created attachment 322752 [details] proposed patch.

Mark Lam

Comment 11 2017-10-04 18:12:59 PDT

Created attachment 322755 [details] proposed patch.

Build Bot

Comment 12 2017-10-04 18:17:18 PDT

Comment on attachment 322755 [details] proposed patch. Attachment 322755 [details] did not pass bindings-ews (mac): Output: http://webkit-queues.webkit.org/results/4760748 New failing tests: (JS) JSTestCallbackFunction.cpp (JS) JSTestCallbackFunctionRethrow.cpp (JS) JSTestCallbackFunctionWithThisObject.cpp (JS) JSTestCallbackFunctionWithTypedefs.cpp (JS) JSTestCallbackInterface.cpp (JS) JSTestObj.cpp (JS) JSTestVoidCallbackFunction.cpp

Mark Lam

Comment 13 2017-10-04 18:21:12 PDT

Created attachment 322756 [details] proposed patch.

Mark Lam

Comment 14 2017-10-04 18:36:14 PDT

Created attachment 322757 [details] proposed patch.

Mark Lam

Comment 15 2017-10-04 18:56:47 PDT

Created attachment 322763 [details] proposed patch: one more time (hopefully this is it).

Build Bot

Comment 16 2017-10-04 20:16:30 PDT

Comment on attachment 322763 [details] proposed patch: one more time (hopefully this is it). Attachment 322763 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4761819 New failing tests: fast/events/constructors/message-event-constructor.html fast/dom/Window/window-postmessage-clone.html

Build Bot

Comment 17 2017-10-04 20:16:32 PDT

Created attachment 322768 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 18 2017-10-04 20:24:06 PDT

Comment on attachment 322763 [details] proposed patch: one more time (hopefully this is it). Attachment 322763 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4761850 New failing tests: fast/events/constructors/message-event-constructor.html

Build Bot

Comment 19 2017-10-04 20:24:07 PDT

Created attachment 322772 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 20 2017-10-04 20:24:59 PDT

Comment on attachment 322763 [details] proposed patch: one more time (hopefully this is it). Attachment 322763 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4761770 New failing tests: fast/events/constructors/message-event-constructor.html accessibility/ios-simulator/video-elements-ios.html

Build Bot

Comment 21 2017-10-04 20:25:00 PDT

Created attachment 322773 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Build Bot

Comment 22 2017-10-04 20:42:04 PDT

Comment on attachment 322763 [details] proposed patch: one more time (hopefully this is it). Attachment 322763 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4761889 New failing tests: fast/events/constructors/message-event-constructor.html fast/dom/Window/window-postmessage-clone-deep-array.html fast/dom/Window/window-postmessage-clone.html

Build Bot

Comment 23 2017-10-04 20:42:06 PDT

Created attachment 322774 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Mark Lam

Comment 24 2017-10-18 11:34:59 PDT

Created attachment 324140 [details] proposed patch: rebased. Let's retry the patch on the latest state of the EWS bots.

Build Bot

Comment 25 2017-10-18 12:56:29 PDT

Comment on attachment 324140 [details] proposed patch: rebased. Attachment 324140 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4906335 New failing tests: fast/events/constructors/message-event-constructor.html fetch/fetch-worker-crash.html fast/dom/Window/window-postmessage-clone.html

Build Bot

Comment 26 2017-10-18 12:56:30 PDT

Created attachment 324151 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 27 2017-10-18 12:58:44 PDT

Comment on attachment 324140 [details] proposed patch: rebased. Attachment 324140 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4906332 New failing tests: fast/events/constructors/message-event-constructor.html fetch/fetch-worker-crash.html

Build Bot

Comment 28 2017-10-18 12:58:46 PDT

Created attachment 324153 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 29 2017-10-18 13:13:49 PDT

Comment on attachment 324140 [details] proposed patch: rebased. Attachment 324140 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4906361 New failing tests: fast/events/constructors/message-event-constructor.html fast/dom/Window/window-postmessage-clone-deep-array.html fast/dom/Window/window-postmessage-clone.html

Build Bot

Comment 30 2017-10-18 13:13:51 PDT

Created attachment 324158 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 31 2017-10-18 13:29:14 PDT

Comment on attachment 324140 [details] proposed patch: rebased. Attachment 324140 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4906516 New failing tests: fast/events/constructors/message-event-constructor.html

Build Bot

Comment 32 2017-10-18 13:29:16 PDT

Created attachment 324163 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Note You need to log in before you can comment on or make changes to this bug.

Status ASSIGNED

Resolution

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebCore JavaScript

Assignee

Mark Lam

Reported

2017-10-03 17:40 PDT

Modified

2017-10-18 13:29 PDT History

CC List

17 users Show

URL

Keywords InRadar

Depends on

Blocks