Bug 177843 - Modernize WebKit's back forward list code
Summary: Modernize WebKit's back forward list code
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Blocks: 182409
  Show dependency treegraph
Reported: 2017-10-03 15:10 PDT by Alex Christensen
Modified: 2018-02-01 15:55 PST (History)
8 users (show)

See Also:

Patch (24.90 KB, patch)
2017-10-03 15:13 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (29.11 KB, patch)
2017-10-03 15:19 PDT, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-10-03 15:10:27 PDT
Moderize WebKit's back forward list code
Comment 1 Alex Christensen 2017-10-03 15:13:05 PDT
Created attachment 322590 [details]
Comment 2 Alex Christensen 2017-10-03 15:19:43 PDT
Created attachment 322592 [details]
Comment 3 Build Bot 2017-10-03 15:20:48 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Tim Horton 2017-10-03 15:24:41 PDT
Comment on attachment 322592 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=322592&action=review

> Source/WebKit/UIProcess/WebBackForwardList.cpp:-76
> -            ASSERT(m_entries[i]);

Did you dig into the reasoning behind this? Seems likely it's not just here for fun, no?
Comment 5 Alex Christensen 2017-10-03 15:31:29 PDT
It's now not needed.  m_entries[i] used to be a RefPtr and now it's a Ref
Comment 6 Alex Christensen 2017-10-03 15:32:01 PDT
In fact, it doesn't compile any more.
Comment 7 Tim Horton 2017-10-03 16:15:42 PDT
Comment 8 Alex Christensen 2017-10-03 17:51:38 PDT
Comment 9 Radar WebKit Bug Importer 2017-10-03 17:52:00 PDT