Bug 177836 - RenderMenuList should not hold raw pointers
Summary: RenderMenuList should not hold raw pointers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-03 14:00 PDT by zalan
Modified: 2017-10-03 15:40 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2017-10-03 14:20 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.42 KB, patch)
2017-10-03 14:29 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-03 14:00:46 PDT 
m_innerBlock and m_buttonText
Comment 1 zalan 2017-10-03 14:20:07 PDT 
Created attachment 322581 [details]
Patch
Comment 2 Antti Koivisto 2017-10-03 14:27:18 PDT 
Comment on attachment 322581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322581&action=review

> Source/WebCore/rendering/RenderMenuList.cpp:109
> +    m_innerBlock = makeWeakPtr(*newInnerBlock.get());

No need for .get()
Comment 3 Antti Koivisto 2017-10-03 14:27:59 PDT 
Comment on attachment 322581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322581&action=review

> Source/WebCore/rendering/RenderMenuList.cpp:296
> +        m_buttonText = makeWeakPtr(*newButtonText.get());

No need for .get()
Comment 4 zalan 2017-10-03 14:29:19 PDT 
Created attachment 322583 [details]
Patch
Comment 5 WebKit Commit Bot 2017-10-03 15:39:54 PDT 
Comment on attachment 322583 [details]
Patch

Clearing flags on attachment: 322583

Committed r222814: <http://trac.webkit.org/changeset/222814>
Comment 6 WebKit Commit Bot 2017-10-03 15:39:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-03 15:40:35 PDT 
<rdar://problem/34801095>