Bug 177830 - Move scroll snap point unregistration from willBeRemovedFromTree to willBeDestroyed
Summary: Move scroll snap point unregistration from willBeRemovedFromTree to willBeDes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-03 12:13 PDT by zalan
Modified: 2017-10-03 17:13 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.75 KB, patch)
2017-10-03 12:18 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-03 12:13:44 PDT
willBeRemovedFromTree is called conditionally, relying on unregistering objects in there is highly error prone.
Comment 1 Radar WebKit Bug Importer 2017-10-03 12:16:02 PDT
<rdar://problem/34796065>
Comment 2 Radar WebKit Bug Importer 2017-10-03 12:18:04 PDT
<rdar://problem/34796100>
Comment 3 zalan 2017-10-03 12:18:34 PDT
Created attachment 322560 [details]
Patch
Comment 4 WebKit Commit Bot 2017-10-03 16:09:08 PDT
The commit-queue encountered the following flaky tests while processing attachment 322560 [details]:

The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2017-10-03 16:09:09 PDT
The commit-queue encountered the following flaky tests while processing attachment 322560 [details]:

The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2017-10-03 17:13:37 PDT
Comment on attachment 322560 [details]
Patch

Clearing flags on attachment: 322560

Committed r222823: <http://trac.webkit.org/changeset/222823>
Comment 7 WebKit Commit Bot 2017-10-03 17:13:38 PDT
All reviewed patches have been landed.  Closing bug.