There are a handful of places where the use of CFNetwork-specific calls are protected by USE(CF). For now, the Windows (Curl) build still uses CoreFoundation, so it would be nice if these were properly conditionalized. The attached patch is based on changes http://bugs.webkit.org/show_bug.cgi?id=17730
Created attachment 19681 [details] Patch to conditionalize based on CFNetwork The attached patch: * Uses "USE(CFNETWORK)" instead of "PLATFORM(CF)" where appropriate. * Fixes a bug in the call to InternetGetCookie, which was previously passing in the new blank UChar vector, rather than the name of the cookie to retrieve.
Comment on attachment 19681 [details] Patch to conditionalize based on CFNetwork You should add a summary of the changes to the ChangeLog. Something like "Compilation fixes when using CoreFoundation but not CFNetwork". r=me, though the ResourceHandle.h change seems out of place in this patch.
Created attachment 19685 [details] Small revision to extend ChangeLog. * Updated Changelog to reference bug and explain change. * Removed "ResourceHandle.h" change. This will be landed in a future patch.
Comment on attachment 19685 [details] Small revision to extend ChangeLog. r=me
Committed revision 30972.