Bug 177798 – [FETCH] Remove Request.type getter

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Dominic Farolino]

As per https://github.com/whatwg/fetch/pull/582 the Request.type getter no longer exists and should be removed. A historical web-platform-test is in the process of being added to assert the non-existence of this attribute (https://github.com/w3c/web-platform-tests/pull/7549).

[youenn fablet]

Created attachment 323329 [details]
Patch

[Build Bot]

Comment on attachment 323329 [details]
Patch

Attachment 323329 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4815179

New failing tests:
imported/w3c/web-platform-tests/fetch/api/basic/integrity-worker.html
imported/w3c/web-platform-tests/fetch/api/request/request-headers.html
imported/w3c/web-platform-tests/fetch/api/basic/integrity.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-combine.html
imported/w3c/web-platform-tests/fetch/api/request/request-error.html
imported/w3c/web-platform-tests/fetch/api/request/request-idl.html
imported/w3c/web-platform-tests/fetch/api/request/request-structure.html
imported/w3c/web-platform-tests/fetch/api/response/response-init-001.html

[Build Bot]

Created attachment 323334 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323329 [details]
Patch

Attachment 323329 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4815199

New failing tests:
imported/w3c/web-platform-tests/fetch/api/basic/integrity-worker.html
imported/w3c/web-platform-tests/fetch/api/request/request-headers.html
imported/w3c/web-platform-tests/fetch/api/basic/integrity.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-combine.html
imported/w3c/web-platform-tests/fetch/api/request/request-error.html
imported/w3c/web-platform-tests/fetch/api/request/request-idl.html
imported/w3c/web-platform-tests/fetch/api/request/request-structure.html
imported/w3c/web-platform-tests/fetch/api/response/response-init-001.html

[Build Bot]

Created attachment 323335 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[youenn fablet]

Created attachment 323337 [details]
Patch

[Chris Dumez]

Comment on attachment 323337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323337&action=review

r=me with comments.

> Source/WebCore/loader/FetchOptions.h:36
> +

I think this is too many blank lines :)

> LayoutTests/imported/w3c/ChangeLog:8
> +       Refreshing fetch WPT tests.

indentation problem.

[youenn fablet]

Created attachment 323934 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 323934 [details]
Patch for landing

Clearing flags on attachment: 323934

Committed r223441: <https://trac.webkit.org/changeset/223441>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35015921>