Bug 177796 - Break out new touch debugging code into separate file
Summary: Break out new touch debugging code into separate file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-02 17:15 PDT by Megan Gardner
Modified: 2018-01-12 17:59 PST (History)
5 users (show)

See Also:


Attachments
Patch (26.15 KB, patch)
2017-10-02 17:21 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (26.22 KB, patch)
2017-10-02 18:59 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (26.30 KB, patch)
2017-10-03 10:57 PDT, Megan Gardner
simon.fraser: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-elcapitan (2.01 MB, application/zip)
2017-10-03 17:29 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2017-10-02 17:15:40 PDT
Break out new touch debugging code into seperate file
Comment 1 Megan Gardner 2017-10-02 17:21:43 PDT
Created attachment 322477 [details]
Patch
Comment 2 Build Bot 2017-10-02 17:23:29 PDT
Attachment 322477 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:47:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:88:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2017-10-02 18:08:28 PDT
Comment on attachment 322477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322477&action=review

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:45
> +    static dispatch_once_t onceToken = 0;

Statics don't need to be initialized to 0, it happens magically!
Comment 4 Megan Gardner 2017-10-02 18:59:07 PDT
Created attachment 322483 [details]
Patch
Comment 5 Build Bot 2017-10-02 19:01:07 PDT
Attachment 322483 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:47:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:88:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Simon Fraser (smfr) 2017-10-03 01:12:32 PDT
Comment on attachment 322483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322483&action=review

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:41
> +@implementation HIDDebugTouchWindow

I think this would read better as GeneratedTouchesDebugWindow or something (the HID isn't really interesting and may change).

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:61
> +- (instancetype)init
> +{
> +    self = [super init];
> +    if (!self)
> +        return nil;
> +    
> +    return self;
> +}

This doesn't nothing; you can remove it.

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:89
> +        UIApplicationRotationFollowingWindow *touchWindow = [[UIApplicationRotationFollowingWindow alloc] init];

Leak, and you overwrite it 2 lines down.

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:90
> +        UIApplicationRotationFollowingControllerNoTouches *viewController = [[UIApplicationRotationFollowingControllerNoTouches alloc] init];

Leak

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:91
> +        touchWindow = [[UIApplicationRotationFollowingWindow alloc] init];

Leak

> Tools/WebKitTestRunner/ios/HIDDebugTouchWindow.mm:105
> +            [newView setBackgroundColor:[UIColor colorWithRed:1.0-i*.05 green:0.0 blue:1.0-i*.05 alpha:0.5]];

Spaces around operators please.
Comment 7 Megan Gardner 2017-10-03 10:57:52 PDT
Created attachment 322548 [details]
Patch
Comment 8 Build Bot 2017-10-03 11:00:44 PDT
Attachment 322548 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:47:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:78:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Build Bot 2017-10-03 17:29:27 PDT
Comment on attachment 322548 [details]
Patch

Attachment 322548 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4746967

New failing tests:
workers/wasm-long-compile.html
Comment 10 Build Bot 2017-10-03 17:29:28 PDT
Created attachment 322617 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Simon Fraser (smfr) 2017-10-04 15:32:39 PDT
Comment on attachment 322548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322548&action=review

> Tools/WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:34
> +static const NSUInteger debugTouchDotRadius = 5;
> +static const NSUInteger debugTouchDotSize = debugTouchDotRadius * 2;

These should be CGFloats

> Tools/WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:98
> +        self.debugTouchViews = [NSArray arrayWithArray:debugViews];

Dunno if it's worth the copy just to make it non-mutable.
Comment 12 Megan Gardner 2018-01-12 17:58:32 PST
https://trac.webkit.org/changeset/222890/webkit
Comment 13 Radar WebKit Bug Importer 2018-01-12 17:59:36 PST
<rdar://problem/36489065>