RESOLVED FIXED177792
A JSFunction's ObjectAllocationProfile should watch the poly prototype watchpoint so it can clear its object allocation profile 
https://bugs.webkit.org/show_bug.cgi?id=177792
Summary A JSFunction's ObjectAllocationProfile should watch the poly prototype watchp...
Saam Barati
Reported 2017-10-02 16:11:49 PDT
...
Attachments
patch (9.20 KB, patch)
2017-10-10 19:59 PDT, Saam Barati 		ysuzuki: review+
DetailsFormatted DiffDiff
patch for landing (9.09 KB, patch)
2017-11-08 14:17 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-10-10 19:03:41 PDT
patch forthcoming
Saam Barati
Comment 2 2017-10-10 19:59:19 PDT
Created attachment 323373 [details] patch
Yusuke Suzuki
Comment 3 2017-10-12 01:13:18 PDT
Comment on attachment 323373 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=323373&action=review r=me > Source/JavaScriptCore/runtime/FunctionRareData.h:114 > + class ClearAllocationProfile : public Watchpoint { How about naming it ClearAllocationProfileWatchpoint?
Saam Barati
Comment 4 2017-11-08 10:58:20 PST
Thanks for the review. I forgot about this patch. Will land it today with your naming suggestion.
Saam Barati
Comment 5 2017-11-08 14:12:19 PST
Comment on attachment 323373 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=323373&action=review >> Source/JavaScriptCore/runtime/FunctionRareData.h:114 >> + class ClearAllocationProfile : public Watchpoint { > > How about naming it ClearAllocationProfileWatchpoint? I'm actually thinking that "AllocationProfileClearingWatchpoint" is a better name and more in line with our other names, like, StructureStubInfoClearingWatchpoint.
Saam Barati
Comment 6 2017-11-08 14:17:52 PST
Created attachment 326372 [details] patch for landing
WebKit Commit Bot
Comment 7 2017-11-08 15:38:59 PST
Comment on attachment 326372 [details] patch for landing Clearing flags on attachment: 326372 Committed r224603: <https://trac.webkit.org/changeset/224603>
WebKit Commit Bot
Comment 8 2017-11-08 15:39:00 PST
All reviewed patches have been landed. Closing bug.
Yusuke Suzuki
Comment 9 2017-11-08 17:57:09 PST
Comment on attachment 323373 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=323373&action=review >>> Source/JavaScriptCore/runtime/FunctionRareData.h:114 >>> + class ClearAllocationProfile : public Watchpoint { >> >> How about naming it ClearAllocationProfileWatchpoint? > > I'm actually thinking that "AllocationProfileClearingWatchpoint" is a better name and more in line with our other names, like, StructureStubInfoClearingWatchpoint. That sounds nice!
Radar WebKit Bug Importer
Comment 10 2017-11-15 09:43:06 PST
<rdar://problem/35562300>
Note You need to log in before you can comment on or make changes to this bug.