Bug 177780 - VMTraps shouldn't crash if it sees an exception it doesn't understand.
Summary: VMTraps shouldn't crash if it sees an exception it doesn't understand.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-02 14:39 PDT by Keith Miller
Modified: 2017-10-02 15:01 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.06 KB, patch)
2017-10-02 14:43 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch for landing (2.06 KB, patch)
2017-10-02 14:48 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch for landing (2.06 KB, patch)
2017-10-02 14:48 PDT, Keith Miller
keith_miller: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-10-02 14:39:35 PDT
VMTraps shouldn't crash if it sees an exception it doesn't understand.
Comment 1 Keith Miller 2017-10-02 14:43:04 PDT
Created attachment 322444 [details]
Patch
Comment 2 Mark Lam 2017-10-02 14:47:24 PDT
Comment on attachment 322444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322444&action=review

r=me with fixes.  Would you happen to have a test for this already?

> Source/JavaScriptCore/ChangeLog:11
> +        noting that this means there's no way to know if, due a bug, we

due *to* a bug.

> Source/JavaScriptCore/runtime/VMTraps.cpp:216
> +                    return SignalAction::HotHandled;

/HotHandled/NotHandled/.
Comment 3 Keith Miller 2017-10-02 14:48:00 PDT
Created attachment 322445 [details]
Patch for landing
Comment 4 Keith Miller 2017-10-02 14:48:36 PDT
Created attachment 322446 [details]
Patch for landing
Comment 5 Mark Lam 2017-10-02 14:48:45 PDT
Comment on attachment 322445 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=322445&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        noting that this means there's no way to know if, due a bug, we

typo still here.
Comment 6 Keith Miller 2017-10-02 14:50:44 PDT
(In reply to Mark Lam from comment #2)
> Comment on attachment 322444 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322444&action=review
> 
> r=me with fixes.  Would you happen to have a test for this already?
> 

I do but it's adding watchdog testing to JSTests/wasm.yaml. Unfortunately, that causes other crashes so I'll land that testing in a follow up.
Comment 7 Keith Miller 2017-10-02 14:54:34 PDT
rdar://problem/33587513
Comment 8 Keith Miller 2017-10-02 14:58:55 PDT
Committed r222748: <http://trac.webkit.org/changeset/222748>