RESOLVED FIXED 177780
VMTraps shouldn't crash if it sees an exception it doesn't understand. 
https://bugs.webkit.org/show_bug.cgi?id=177780
Summary VMTraps shouldn't crash if it sees an exception it doesn't understand.
Keith Miller
Reported 2017-10-02 14:39:35 PDT
VMTraps shouldn't crash if it sees an exception it doesn't understand.
Attachments
Patch (2.06 KB, patch)
2017-10-02 14:43 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.06 KB, patch)
2017-10-02 14:48 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.06 KB, patch)
2017-10-02 14:48 PDT, Keith Miller 		keith_miller: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-10-02 14:43:04 PDT
Created attachment 322444 [details] Patch
Mark Lam
Comment 2 2017-10-02 14:47:24 PDT
Comment on attachment 322444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322444&action=review r=me with fixes. Would you happen to have a test for this already? > Source/JavaScriptCore/ChangeLog:11 > + noting that this means there's no way to know if, due a bug, we due *to* a bug. > Source/JavaScriptCore/runtime/VMTraps.cpp:216 > + return SignalAction::HotHandled; /HotHandled/NotHandled/.
Keith Miller
Comment 3 2017-10-02 14:48:00 PDT
Created attachment 322445 [details] Patch for landing
Keith Miller
Comment 4 2017-10-02 14:48:36 PDT
Created attachment 322446 [details] Patch for landing
Mark Lam
Comment 5 2017-10-02 14:48:45 PDT
Comment on attachment 322445 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=322445&action=review > Source/JavaScriptCore/ChangeLog:11 > + noting that this means there's no way to know if, due a bug, we typo still here.
Keith Miller
Comment 6 2017-10-02 14:50:44 PDT
(In reply to Mark Lam from comment #2) > Comment on attachment 322444 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322444&action=review > > r=me with fixes. Would you happen to have a test for this already? > I do but it's adding watchdog testing to JSTests/wasm.yaml. Unfortunately, that causes other crashes so I'll land that testing in a follow up.
Keith Miller
Comment 7 2017-10-02 14:54:34 PDT
rdar://problem/33587513
Keith Miller
Comment 8 2017-10-02 14:58:55 PDT
Committed r222748: <http://trac.webkit.org/changeset/222748>
Note You need to log in before you can comment on or make changes to this bug.