Bug 177778 – PasteImage tests are failing on debug builds

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryosuke Niwa]

PasteImage tests are failing on debug builds

[Ryosuke Niwa]

Created attachment 322433 [details]
Fixes the bug

[Wenson Hsieh]

Comment on attachment 322433 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=322433&action=review

> Source/WebCore/ChangeLog:8
> +        After r222702, we're not supposed to be adding "Files" as types. Removed the code to do this

I think it'd be more accurate to say "...PlatformPasteboard is no longer responsible for adding "Files" as a type..." here, since "Files" is still added as a type, it's just that DataTransfer takes care of it now.

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:1036
> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110300

I think we'll also need to define out a couple of static helpers above that will no longer be used on iOS 11.0, otherwise the build will complain about unused code. I can take care of this in a separate change (as test gardening).

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 322433 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322433&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        After r222702, we're not supposed to be adding "Files" as types. Removed the code to do this
> 
> I think it'd be more accurate to say "...PlatformPasteboard is no longer
> responsible for adding "Files" as a type..." here, since "Files" is still
> added as a type, it's just that DataTransfer takes care of it now.
> 
> > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:1036
> > +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110300
> 
> I think we'll also need to define out a couple of static helpers above that
> will no longer be used on iOS 11.0, otherwise the build will complain about
> unused code. I can take care of this in a separate change (as test
> gardening).

Landed in https://trac.webkit.org/changeset/222743/webkit.

[Ryosuke Niwa]

Created attachment 322442 [details]
Patch for landing

[Ryosuke Niwa]

Comment on attachment 322442 [details]
Patch for landing

Clearing flags on attachment: 322442

Committed r222746: <http://trac.webkit.org/changeset/222746>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34777058>