Bug 177778 - PasteImage tests are failing on debug builds
Summary: PasteImage tests are failing on debug builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-02 13:57 PDT by Ryosuke Niwa
Modified: 2017-10-02 15:01 PDT (History)
5 users (show)

See Also:

Attachments
Fixes the bug (4.90 KB, patch)
2017-10-02 13:59 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (3.21 KB, patch)
2017-10-02 14:39 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-10-02 13:57:41 PDT 
PasteImage tests are failing on debug builds
Comment 1 Ryosuke Niwa 2017-10-02 13:59:56 PDT 
Created attachment 322433 [details]
Fixes the bug
Comment 2 Wenson Hsieh 2017-10-02 14:08:17 PDT 
Comment on attachment 322433 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=322433&action=review

> Source/WebCore/ChangeLog:8
> +        After r222702, we're not supposed to be adding "Files" as types. Removed the code to do this

I think it'd be more accurate to say "...PlatformPasteboard is no longer responsible for adding "Files" as a type..." here, since "Files" is still added as a type, it's just that DataTransfer takes care of it now.

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:1036
> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110300

I think we'll also need to define out a couple of static helpers above that will no longer be used on iOS 11.0, otherwise the build will complain about unused code. I can take care of this in a separate change (as test gardening).
Comment 3 Wenson Hsieh 2017-10-02 14:36:26 PDT 
(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 322433 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322433&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        After r222702, we're not supposed to be adding "Files" as types. Removed the code to do this
> 
> I think it'd be more accurate to say "...PlatformPasteboard is no longer
> responsible for adding "Files" as a type..." here, since "Files" is still
> added as a type, it's just that DataTransfer takes care of it now.
> 
> > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:1036
> > +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110300
> 
> I think we'll also need to define out a couple of static helpers above that
> will no longer be used on iOS 11.0, otherwise the build will complain about
> unused code. I can take care of this in a separate change (as test
> gardening).

Landed in https://trac.webkit.org/changeset/222743/webkit.
Comment 4 Ryosuke Niwa 2017-10-02 14:39:57 PDT 
Created attachment 322442 [details]
Patch for landing
Comment 5 Ryosuke Niwa 2017-10-02 14:44:08 PDT 
Comment on attachment 322442 [details]
Patch for landing

Clearing flags on attachment: 322442

Committed r222746: <http://trac.webkit.org/changeset/222746>
Comment 6 Ryosuke Niwa 2017-10-02 14:44:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-02 14:45:35 PDT 
<rdar://problem/34777058>