Bug 177774 – Web Inspector: After enabling the new Network Tab in experimental settings, the network tab disappears

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

After enabling the new Network Tab in experimental settings, the network tab disappears.

Steps to reproduce:
1. Open Web Inspector
2. Click the gear for settings
3. Click Experimental
4. Check New Network Tab
5. Reload the inspector with the button that appears

Result:
Network Tab disappears.

Expected:
Network Tab to be there just different.

Note:
It is possible to add it back with New Tab however.

[Joseph Pecoraro]

<rdar://problem/34771647>

[Joseph Pecoraro]

Created attachment 322425 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 322425 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=322425&action=review

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:259
> +                if (!WI.settings.experimentalEnableNewNetworkTab.value)

Shouldn't the reverse also be done (replace WI.NetworkTabContentView with WI.LEgacyNetworkTabContentView) if the setting changes to off?  Also, doesn't a warning appear when you toggle this setting that you have to refresh to see the effects?  Maybe a better solution would be to force a refresh if the user switches off the settings tab without clicking that button :|

[Joseph Pecoraro]

Comment on attachment 322425 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=322425&action=review

>> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:259
>> +                if (!WI.settings.experimentalEnableNewNetworkTab.value)
> 
> Shouldn't the reverse also be done (replace WI.NetworkTabContentView with WI.LEgacyNetworkTabContentView) if the setting changes to off?  Also, doesn't a warning appear when you toggle this setting that you have to refresh to see the effects?  Maybe a better solution would be to force a refresh if the user switches off the settings tab without clicking that button :|

Sure I can do this for the legacy direction.

[Joseph Pecoraro]

Created attachment 322622 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 322622 [details]
[PATCH] Proposed Fix

r=me

[WebKit Commit Bot]

Comment on attachment 322622 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 322622

Committed r222860: <http://trac.webkit.org/changeset/222860>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.