Bug 177771 - Web Inspector: Ensure popovers are not malformed on window resize.
Summary: Web Inspector: Ensure popovers are not malformed on window resize.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-02 13:24 PDT by Ross Kirsling
Modified: 2017-10-02 14:32 PDT (History)
5 users (show)

See Also:

Attachments
Screenshot of malformed popover (96.04 KB, image/png)
2017-10-02 13:27 PDT, Ross Kirsling 		no flags Details
Patch (1.83 KB, patch)
2017-10-02 13:28 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (1.93 KB, patch)
2017-10-02 13:42 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2017-10-02 13:24:44 PDT 
(Discovered as part of https://bugs.webkit.org/show_bug.cgi?id=177477.)

Repro:
1. View the Layers sidebar and click on a data grid row.
2. Squash the Web Inspector window horizontally until the popover needs to be repositioned vertically.
>> The popover no longer contains its content properly after it is repositioned.

Reason:
`arrow-*` CSS classes are not being removed from popovers when re-`present`ing a popover from the window resize handler.
Comment 1 Ross Kirsling 2017-10-02 13:27:50 PDT 
Created attachment 322420 [details]
Screenshot of malformed popover
Comment 2 Ross Kirsling 2017-10-02 13:28:46 PDT 
Created attachment 322421 [details]
Patch
Comment 3 Joseph Pecoraro 2017-10-02 13:31:06 PDT 
Comment on attachment 322421 [details]
Patch

r=me This sounds good to me. A description in the ChangeLog about why would be nice.
Comment 4 Ross Kirsling 2017-10-02 13:42:29 PDT 
Created attachment 322424 [details]
Patch
Comment 5 WebKit Commit Bot 2017-10-02 14:31:38 PDT 
Comment on attachment 322424 [details]
Patch

Clearing flags on attachment: 322424

Committed r222742: <http://trac.webkit.org/changeset/222742>
Comment 6 WebKit Commit Bot 2017-10-02 14:31:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-02 14:32:20 PDT 
<rdar://problem/34776681>