RESOLVED FIXED 177765
Make pertinent AccessCases watch the poly proto watchpoint 
https://bugs.webkit.org/show_bug.cgi?id=177765
Summary Make pertinent AccessCases watch the poly proto watchpoint
Saam Barati
Reported 2017-10-02 12:53:48 PDT
What will happen today is each individual IC will figure out if the prototype watchpoint should have fired on its own. And they may or may not clear their pre-poly-prototype contents. It's probably more efficient for all of them to clear their data. This is a good follow up to the poly prototype patch.
Attachments
patch (59.50 KB, patch)
2017-10-04 16:41 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-10-04 14:04:48 PDT
Starting this now.
Saam Barati
Comment 2 2017-10-04 16:41:19 PDT
Created attachment 322740 [details] patch
Saam Barati
Comment 3 2017-10-04 16:42:20 PDT
Comment on attachment 322740 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=322740&action=review > Source/JavaScriptCore/jit/Repatch.cpp:169 > +static InlineCacheAction tryCacheGetByID(ExecState* exec, JSValue baseValue, const Identifier& propertyName, const PropertySlot& slot, StructureStubInfo& stubInfo, GetByIDKind kind) The diff for this file was not generated well. The only thing I'm doing here is moving where we acquire the lock in more so we don't call fireWatchpointsAndClearStubIfNeeded with the lock held.
Keith Miller
Comment 4 2017-10-04 17:57:59 PDT
Comment on attachment 322740 [details] patch r=me.
WebKit Commit Bot
Comment 5 2017-10-04 19:48:03 PDT
Comment on attachment 322740 [details] patch Clearing flags on attachment: 322740 Committed r222891: <http://trac.webkit.org/changeset/222891>
WebKit Commit Bot
Comment 6 2017-10-04 19:48:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-10-04 19:48:41 PDT
<rdar://problem/34826781>
Note You need to log in before you can comment on or make changes to this bug.