Bug 177765 - Make pertinent AccessCases watch the poly proto watchpoint
Summary: Make pertinent AccessCases watch the poly proto watchpoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-02 12:53 PDT by Saam Barati
Modified: 2017-10-04 19:48 PDT (History)
13 users (show)

See Also:

Attachments
patch (59.50 KB, patch)
2017-10-04 16:41 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-10-02 12:53:48 PDT 
What will happen today is each individual IC will figure out if the prototype watchpoint should have fired on its own. And they may or may not clear their pre-poly-prototype contents. It's probably more efficient for all of them to clear their data. This is a good follow up to the poly prototype patch.
Comment 1 Saam Barati 2017-10-04 14:04:48 PDT 
Starting this now.
Comment 2 Saam Barati 2017-10-04 16:41:19 PDT 
Created attachment 322740 [details]
patch
Comment 3 Saam Barati 2017-10-04 16:42:20 PDT 
Comment on attachment 322740 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322740&action=review

> Source/JavaScriptCore/jit/Repatch.cpp:169
> +static InlineCacheAction tryCacheGetByID(ExecState* exec, JSValue baseValue, const Identifier& propertyName, const PropertySlot& slot, StructureStubInfo& stubInfo, GetByIDKind kind)

The diff for this file was not generated well. The only thing I'm doing here is moving where we acquire the lock in more so we don't call fireWatchpointsAndClearStubIfNeeded with the lock held.
Comment 4 Keith Miller 2017-10-04 17:57:59 PDT 
Comment on attachment 322740 [details]
patch

r=me.
Comment 5 WebKit Commit Bot 2017-10-04 19:48:03 PDT 
Comment on attachment 322740 [details]
patch

Clearing flags on attachment: 322740

Committed r222891: <http://trac.webkit.org/changeset/222891>
Comment 6 WebKit Commit Bot 2017-10-04 19:48:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-04 19:48:41 PDT 
<rdar://problem/34826781>