Bug 177763 – AX: [ATK] ARIA drag-and-drop attribute values should be exposed via AtkObject attributes

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

The values of aria-grabbed and aria-dropeffect are not exposed via ATK. The Core AAM states they should be exposed via AtkObject attributes.

[Radar WebKit Bug Importer]

<rdar://problem/34772635>

[Joanmarie Diggs]

Created attachment 322407 [details]
Patch

[Joanmarie Diggs]

Created attachment 322494 [details]
Patch

[chris fleizach]

Comment on attachment 322494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322494&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:586
> +        attributeSet = addToAtkAttributeSet(attributeSet, "grabbed", "false");

is this bit tested? doesn't look like there's a WTR method for checking aria dragging presence

[Joanmarie Diggs]

Comment on attachment 322494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322494&action=review

>> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:586
>> +        attributeSet = addToAtkAttributeSet(attributeSet, "grabbed", "false");
> 
> is this bit tested? doesn't look like there's a WTR method for checking aria dragging presence

It was tested back when I was just dumping object attributes (before I found the unimplemented WTR methods). I'll add dumping into the revised test. Thanks for catching that!

[Joanmarie Diggs]

Created attachment 322497 [details]
Patch

[Build Bot]

Comment on attachment 322497 [details]
Patch

Attachment 322497 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4738425

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 322508 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Joanmarie Diggs]

Comment on attachment 322497 [details]
Patch

Resetting cq+. This patch only touches Linux accessibility code. Thus I really cannot imagine it's breaking non-accessibility mac tests. If I'm wrong, please explain what I'm missing.

[WebKit Commit Bot]

Comment on attachment 322497 [details]
Patch

Clearing flags on attachment: 322497

Committed r222787: <http://trac.webkit.org/changeset/222787>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.