Bug 177763 - AX: [ATK] ARIA drag-and-drop attribute values should be exposed via AtkObject attributes
Summary: AX: [ATK] ARIA drag-and-drop attribute values should be exposed via AtkObject...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All Linux
: P2 Normal
Assignee: Joanmarie Diggs
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-02 12:01 PDT by Joanmarie Diggs
Modified: 2017-10-03 10:56 PDT (History)
10 users (show)

See Also:

Attachments
Patch (6.01 KB, patch)
2017-10-02 12:04 PDT, Joanmarie Diggs 		no flags Details | Formatted Diff | Diff
Patch (7.26 KB, patch)
2017-10-02 23:45 PDT, Joanmarie Diggs 		no flags Details | Formatted Diff | Diff
Patch (7.97 KB, patch)
2017-10-03 00:21 PDT, Joanmarie Diggs 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.78 MB, application/zip)
2017-10-03 04:35 PDT, Build Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2017-10-02 12:01:10 PDT 
The values of aria-grabbed and aria-dropeffect are not exposed via ATK. The Core AAM states they should be exposed via AtkObject attributes.
Comment 1 Radar WebKit Bug Importer 2017-10-02 12:01:49 PDT 
<rdar://problem/34772635>
Comment 2 Joanmarie Diggs 2017-10-02 12:04:55 PDT 
Created attachment 322407 [details]
Patch
Comment 3 Joanmarie Diggs 2017-10-02 23:45:27 PDT 
Created attachment 322494 [details]
Patch
Comment 4 chris fleizach 2017-10-02 23:53:15 PDT 
Comment on attachment 322494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322494&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:586
> +        attributeSet = addToAtkAttributeSet(attributeSet, "grabbed", "false");

is this bit tested? doesn't look like there's a WTR method for checking aria dragging presence
Comment 5 Joanmarie Diggs 2017-10-03 00:03:14 PDT 
Comment on attachment 322494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322494&action=review

>> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:586
>> +        attributeSet = addToAtkAttributeSet(attributeSet, "grabbed", "false");
> 
> is this bit tested? doesn't look like there's a WTR method for checking aria dragging presence

It was tested back when I was just dumping object attributes (before I found the unimplemented WTR methods). I'll add dumping into the revised test. Thanks for catching that!
Comment 6 Joanmarie Diggs 2017-10-03 00:21:45 PDT 
Created attachment 322497 [details]
Patch
Comment 7 Build Bot 2017-10-03 04:35:42 PDT 
Comment on attachment 322497 [details]
Patch

Attachment 322497 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4738425

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2017-10-03 04:35:43 PDT 
Created attachment 322508 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 9 Joanmarie Diggs 2017-10-03 04:48:17 PDT 
Comment on attachment 322497 [details]
Patch

Resetting cq+. This patch only touches Linux accessibility code. Thus I really cannot imagine it's breaking non-accessibility mac tests. If I'm wrong, please explain what I'm missing.
Comment 10 WebKit Commit Bot 2017-10-03 10:56:53 PDT 
Comment on attachment 322497 [details]
Patch

Clearing flags on attachment: 322497

Committed r222787: <http://trac.webkit.org/changeset/222787>
Comment 11 WebKit Commit Bot 2017-10-03 10:56:55 PDT 
All reviewed patches have been landed.  Closing bug.