Bug 177749 - Use InlineTextBox::lineFont() in more places
Summary: Use InlineTextBox::lineFont() in more places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-02 09:48 PDT by Daniel Bates
Modified: 2017-10-02 16:45 PDT (History)
5 users (show)

See Also:


Attachments
Patch (12.93 KB, patch)
2017-10-02 09:55 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-elcapitan (1.82 MB, application/zip)
2017-10-02 11:21 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-10-02 09:48:05 PDT
Use InlineTextBox::lineFont() in more places instead of passing it around.
Comment 1 Daniel Bates 2017-10-02 09:55:08 PDT
Created attachment 322382 [details]
Patch
Comment 2 Build Bot 2017-10-02 11:21:29 PDT
Comment on attachment 322382 [details]
Patch

Attachment 322382 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4725608

New failing tests:
imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-screenx-screeny.html
Comment 3 Build Bot 2017-10-02 11:21:31 PDT
Created attachment 322396 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Daniel Bates 2017-10-02 12:24:54 PDT
(In reply to Build Bot from comment #2)
> Comment on attachment 322382 [details]
> Patch
> 
> Attachment 322382 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/4725608
> 
> New failing tests:
> imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-
> creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-
> screenx-screeny.html

This failure is unrelated to this patch.
Comment 5 Daniel Bates 2017-10-02 16:44:41 PDT
Comment on attachment 322382 [details]
Patch

Clearing flags on attachment: 322382

Committed r222758: <http://trac.webkit.org/changeset/222758>
Comment 6 Daniel Bates 2017-10-02 16:44:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-02 16:45:35 PDT
<rdar://problem/34780472>