Bug 177747 - Make LibWebRTCProvider port agnostic
Summary: Make LibWebRTCProvider port agnostic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-02 09:09 PDT by youenn fablet
Modified: 2017-10-05 00:45 PDT (History)
6 users (show)

See Also:

Attachments
Patch (22.40 KB, patch)
2017-10-02 10:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (21.98 KB, patch)
2017-10-02 10:48 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (23.05 KB, patch)
2017-10-02 13:50 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (23.09 KB, patch)
2017-10-02 14:48 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (23.11 KB, patch)
2017-10-02 15:09 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (23.11 KB, patch)
2017-10-03 01:53 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-elcapitan (1.94 MB, application/zip)
2017-10-03 21:14 PDT, Build Bot 		no flags Details
Patch for landing (22.42 KB, patch)
2017-10-04 23:46 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (23.13 KB, patch)
2017-10-04 23:56 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-10-02 09:09:55 PDT 
Currently it is cocoa specific.
Comment 1 youenn fablet 2017-10-02 10:23:18 PDT 
Created attachment 322386 [details]
Patch
Comment 2 youenn fablet 2017-10-02 10:48:54 PDT 
Created attachment 322391 [details]
Patch
Comment 3 youenn fablet 2017-10-02 13:50:27 PDT 
Created attachment 322426 [details]
Patch
Comment 4 youenn fablet 2017-10-02 14:48:43 PDT 
Created attachment 322447 [details]
Patch
Comment 5 youenn fablet 2017-10-02 15:09:14 PDT 
Created attachment 322450 [details]
Patch
Comment 6 youenn fablet 2017-10-03 01:53:45 PDT 
Created attachment 322503 [details]
Patch
Comment 7 Alex Christensen 2017-10-03 18:15:16 PDT 
Comment on attachment 322503 [details]
Patch

I like this.  I'd like to see an indication of buy-in from non-cocoa ports before landing this would make much sense.
Comment 8 youenn fablet 2017-10-03 18:19:56 PDT 
The plan might be to make LibWebRTCProvider::createPeerConnectionFactory virtual so that GTK port will use a different way to create a factory. This might depend on whether they will use libwebrtc for capture or not.
Specificying codec factories is also of interest to GTK port.

Alex, can you confirm or clarify things for GTK port?
Comment 9 Build Bot 2017-10-03 21:14:12 PDT 
Comment on attachment 322503 [details]
Patch

Attachment 322503 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4748614

New failing tests:
workers/wasm-hashset.html
Comment 10 Build Bot 2017-10-03 21:14:13 PDT 
Created attachment 322628 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Alejandro G. Castro 2017-10-04 03:31:47 PDT 
Comment on attachment 322503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322503&action=review

LGTM, we need this to use the provider at all, and later as youenn is explaning we need a way to get or set the factory from the platform.

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:31
> +#include "LibWebRTCProviderCocoa.h"

We don't need this one, it is in the LibWebRTCProvider.h
Comment 12 youenn fablet 2017-10-04 08:31:54 PDT 
Comment on attachment 322503 [details]
Patch

Error is unrelated.
I will update the patch in a follow-up or at landing time according Alex comment.
Comment 13 youenn fablet 2017-10-04 23:46:00 PDT 
Created attachment 322792 [details]
Patch for landing
Comment 14 youenn fablet 2017-10-04 23:56:39 PDT 
Created attachment 322795 [details]
Patch for landing
Comment 15 WebKit Commit Bot 2017-10-05 00:44:38 PDT 
Comment on attachment 322795 [details]
Patch for landing

Clearing flags on attachment: 322795

Committed r222902: <http://trac.webkit.org/changeset/222902>
Comment 16 WebKit Commit Bot 2017-10-05 00:44:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 17 Radar WebKit Bug Importer 2017-10-05 00:45:07 PDT 
<rdar://problem/34829223>