RESOLVED FIXED 177742
[GTK] Do not hardcode font family in served remote inspector HTML snippets 
https://bugs.webkit.org/show_bug.cgi?id=177742
Summary [GTK] Do not hardcode font family in served remote inspector HTML snippets
Adrian Perez
Reported 2017-10-02 06:44:04 PDT
There's a string with a HTML+CSS snippet in Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp which contains a hardcoded font. It seems like it would be a good idea to not hardcode this.
Attachments
Patch (2.28 KB, patch)
2017-10-02 06:49 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.26 KB, patch)
2017-10-02 14:38 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2017-10-02 06:45:55 PDT
This could be done in a similar way as this patch in Epiphany: https://bugzilla.gnome.org/show_bug.cgi?id=783489 It uses “font:menu” to obtain the system font, which is supported since CSS 2. I'll be sending a patch.
Adrian Perez
Comment 2 2017-10-02 06:49:01 PDT
Created attachment 322373 [details] Patch
Build Bot
Comment 3 2017-10-02 06:51:47 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Adrian Perez
Comment 4 2017-10-02 14:38:24 PDT
Created attachment 322441 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-10-02 15:01:01 PDT
Comment on attachment 322441 [details] Patch for landing Clearing flags on attachment: 322441 Committed r222749: <http://trac.webkit.org/changeset/222749>
WebKit Commit Bot
Comment 6 2017-10-02 15:01:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-10-02 15:01:50 PDT
<rdar://problem/34777611>
Note You need to log in before you can comment on or make changes to this bug.