Bug 177741 – [GLib] NetworkStateNotifier implementation missing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Gustavo Noronha (kov)]

[GLib] NetworkStateNotifier implementation missing

[Gustavo Noronha (kov)]

Created attachment 322372 [details]
Patch

[Gustavo Noronha (kov)]

I used this to test: http://html5-demos.appspot.com/static/navigator.onLine.html

[Carlos Garcia Campos]

Comment on attachment 322372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322372&action=review

> Source/WebCore/platform/network/NetworkStateNotifier.cpp:78
>  
> -#if !PLATFORM(IOS) && !PLATFORM(MAC) && !PLATFORM(WIN)
> +#if !PLATFORM(IOS) && !PLATFORM(MAC) && !PLATFORM(WIN) && !PLATFORM(GTK) && !PLATFORM(WPE)

So, can we remove the stubs now then?

> Source/WebCore/platform/network/glib/NetworkStateNotifierGLib.cpp:29
> +    GNetworkMonitor* monitor = g_network_monitor_get_default();
> +    m_isOnLine = g_network_monitor_get_network_available(monitor);

This can be one line, we don't need the local variable.

> Source/WebCore/platform/network/glib/NetworkStateNotifierGLib.cpp:40
> +    GNetworkMonitor* monitor = g_network_monitor_get_default();
> +    g_signal_connect(monitor, "network-changed", G_CALLBACK(networkChangedCallback), this);

Ditto. Since we don't really use the monitor in the callback we could use connect swapped and the callbck would only receive the NetworkStateNotifier and we don't need the forward declaration in the header either.

[Michael Catanzaro]

Comment on attachment 322372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322372&action=review

>> Source/WebCore/platform/network/NetworkStateNotifier.cpp:78
>> +#if !PLATFORM(IOS) && !PLATFORM(MAC) && !PLATFORM(WIN) && !PLATFORM(GTK) && !PLATFORM(WPE)
> 
> So, can we remove the stubs now then?

Yeah, looks like it's #if !EVERYTHING now!

[Gustavo Noronha (kov)]

Created attachment 322383 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 322383 [details]
Patch for landing

Clearing flags on attachment: 322383

Committed r222723: <http://trac.webkit.org/changeset/222723>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.