Bug 177737 - [GTK][WPE] Enable interactive forms validation by default
Summary: [GTK][WPE] Enable interactive forms validation by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-02 02:05 PDT by Carlos Garcia Campos
Modified: 2017-10-02 07:33 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.16 KB, patch)
2017-10-02 02:07 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-10-02 02:05:21 PDT 
It's currently disabled for no reason.
Comment 1 Carlos Garcia Campos 2017-10-02 02:07:14 PDT 
Created attachment 322363 [details]
Patch
Comment 2 Michael Catanzaro 2017-10-02 04:40:48 PDT 
Comment on attachment 322363 [details]
Patch

No r+ from me because you've left it disabled on Windows for no reason. We should get rid of DEFAULT_HTML_INTERACTIVE_FORM_VALIDATION_ENABLED and just hardcode the default value as true.
Comment 3 Carlos Garcia Campos 2017-10-02 04:59:05 PDT 
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 322363 [details]
> Patch
> 
> No r+ from me because you've left it disabled on Windows for no reason. We
> should get rid of DEFAULT_HTML_INTERACTIVE_FORM_VALIDATION_ENABLED and just
> hardcode the default value as true.

Windows? there's no windows wk2 port? I can remove the ifdef before landing
Comment 4 Michael Catanzaro 2017-10-02 05:34:43 PDT 
Comment on attachment 322363 [details]
Patch

OK, with the ifdef removed

Windows WK2 port is WIP. The PlatformWin.cmake is already in place.
Comment 5 Carlos Garcia Campos 2017-10-02 07:33:01 PDT 
Committed r222708: <http://trac.webkit.org/changeset/222708>