Bug 177733 – [curl] Crashes in CurlRequest::setupPUT()

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Fujii Hironori]

[curl] Crashes in CurlRequest::setupPUT()

MiniBrowser crashed while browsing CNN and Google News.
I tested with trunk@222695, WinCairo port, Debug build, MiniBrowser.

Callstack:

> WebKit.dll!WTF::Vector<WebCore::FormDataElement,0,WTF::CrashOnOverflow,16,WTF::FastMalloc>::size() Line 647	C++
> WebKit.dll!WebCore::CurlRequest::setupPUT(WebCore::ResourceRequest & request) Line 384	C++
> WebKit.dll!WebCore::CurlRequest::setupTransfer() Line 159	C++
> WebKit.dll!WebCore::CurlJobList::startJobs(WTF::HashSet<WebCore::CurlJobClient *,WTF::PtrHash<WebCore::CurlJobClient *>,WTF::HashTraits<WebCore::CurlJobClient *> > && jobs) Line 46	C++
> WebKit.dll!WebCore::CurlJobManager::updateJobList(WebCore::CurlJobList & jobs) Line 178	C++
> WebKit.dll!WebCore::CurlJobManager::workerThread() Line 197	C++
> WebKit.dll!WebCore::CurlJobManager::startThreadIfNeeded::__l10::<lambda>() Line 132	C++
> WebKit.dll!WTF::Function<void __cdecl(void)>::CallableWrapper<void <lambda>(void) >::call() Line 101	C++
> WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 57	C++
> WTF.dll!WTF::Thread::entryPoint(WTF::Thread::NewThreadContext * newThreadContext) Line 130	C++
> WTF.dll!WTF::wtfThreadEntryPoint(void * data) Line 157	C++
> WTF.dll!thread_start<unsigned int (__cdecl*)(void * __ptr64)>(void * const parameter) Line 115	C++
> [External Code]	


> auto numElements = request.httpBody()->elements().size();

request.httpBody() was null.

[Fujii Hironori]

A variable 'method' was "OPTIONS" in CurlRequest::setupTransfer().

[Fujii Hironori]

A test http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html crashes.

[Fujii Hironori]

Created attachment 322356 [details]
Patch

[Build Bot]

Comment on attachment 322356 [details]
Patch

Attachment 322356 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4721522

New failing tests:
http/tests/security/window-properties-clear-domain.html

[Build Bot]

Created attachment 322362 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[WebKit Commit Bot]

Comment on attachment 322356 [details]
Patch

Clearing flags on attachment: 322356

Committed r222730: <http://trac.webkit.org/changeset/222730>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34772741>